core(audits): Point SEO audit links to web.dev #9537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfriesenhahn
requested review from
brendankenny,
exterkamp,
patrickhulce and
paulirish
as code owners
patrickhulce
approved these changes
Aug 9, 2019
| @@ -63,7 +63,7 @@ const UIStrings = { | |||
| failureTitle: 'Links do not have descriptive text', | |||
| /** Description of a Lighthouse audit that tells the user *why* they need to have descriptive text on the links in their page. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */ | |||
| description: 'Descriptive link text helps search engines understand your content. ' + | |||
| '[Learn more](https://developers.google.com/web/tools/lighthouse/audits/descriptive-link-text).', | |||
| '[Learn more](https://web.dev/link-text).', | |||
There was a problem hiding this comment.
FYI the screenshot in this doc is of a Lighthouse error/bug instead of the audit failing
| @@ -25,7 +25,7 @@ const UIStrings = { | |||
| /** Description of a Lighthouse audit that tells the user *why* allowing search-engine crawling of their page is beneficial. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */ | |||
| description: 'Search engines are unable to include your pages in search results ' + | |||
| 'if they don\'t have permission to crawl them. [Learn ' + | |||
| 'more](https://developers.google.com/web/tools/lighthouse/audits/indexing).', | |||
| 'more](https://web.dev/is-crawable).', | |||
There was a problem hiding this comment.
FYI the screenshot in this doc is of a Lighthouse error/bug instead of the audit failing
| @@ -41,7 +41,7 @@ const UIStrings = { | |||
| /** Description of a Lighthouse audit that tells the user *why* they need to avoid using browser plugins in their content. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */ | |||
| description: 'Search engines can\'t index plugin content, and ' + | |||
| 'many devices restrict plugins or don\'t support them. ' + | |||
| '[Learn more](https://developers.google.com/web/tools/lighthouse/audits/plugins).', | |||
| '[Learn more](https://web.dev/plugins).', | |||
There was a problem hiding this comment.
FYI the screenshot in this doc is of a Lighthouse error/bug instead of the audit failing
11 tasks
exterkamp
approved these changes
Aug 9, 2019
exterkamp
requested changes
Aug 10, 2019
That one's taken care of in #9539. |
exterkamp
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Points "Learn more" links in SEO audits to relevant web.dev guides.
viewport.jshandled in core(audits): point PWA audit description links to web.dev #9539Note
The robots.txt is not valid audit didn't have a "Learn more" link, so I added one.