Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(audits): Point SEO audit links to web.dev #9537

Merged
merged 2 commits into from
Aug 13, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lighthouse-core/audits/seo/canonical.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const UIStrings = {
failureTitle: 'Document does not have a valid `rel=canonical`',
/** Description of a Lighthouse audit that tells the user *why* they need to have a valid rel=canonical link. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */
description: 'Canonical links suggest which URL to show in search results. ' +
'[Learn more](https://developers.google.com/web/tools/lighthouse/audits/canonical).',
'[Learn more](https://web.dev/canonical).',
/**
* @description Explanatory message stating that there was a failure in an audit caused by multiple URLs conflicting with each other.
* @example {https://example.com, https://example2.com} urlList
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/seo/font-size.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const UIStrings = {
/** Title of a Lighthouse audit that provides detail on the font sizes used on the page. This descriptive title is shown to users when there is a font that may be too small to be read by users. */
failureTitle: 'Document doesn\'t use legible font sizes',
/** Description of a Lighthouse audit that tells the user *why* they need to use a larger font size. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */
description: 'Font sizes less than 12px are too small to be legible and require mobile visitors to “pinch to zoom” in order to read. Strive to have >60% of page text ≥12px. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/font-sizes).',
description: 'Font sizes less than 12px are too small to be legible and require mobile visitors to “pinch to zoom” in order to read. Strive to have >60% of page text ≥12px. [Learn more](https://web.dev/font-size).',
/** Label for the audit identifying font sizes that are too small. */
displayValue: '{decimalProportion, number, extendedPercent} legible text',
/** Explanatory message stating that there was a failure in an audit caused by a missing page viewport meta tag configuration. "viewport" and "meta" are HTML terms and should not be translated. */
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/seo/hreflang.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const UIStrings = {
/** Description of a Lighthouse audit that tells the user *why* they need to have an hreflang link on their page. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. "hreflang" is an HTML attribute and should not be translated. */
description: 'hreflang links tell search engines what version of a page they should ' +
'list in search results for a given language or region. [Learn more]' +
'(https://developers.google.com/web/tools/lighthouse/audits/hreflang).',
'(https://web.dev/hreflang).',
};

const str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings);
Expand Down
3 changes: 1 addition & 2 deletions lighthouse-core/audits/seo/http-status-code.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ const UIStrings = {
failureTitle: 'Page has unsuccessful HTTP status code',
/** Description of a Lighthouse audit that tells the user *why* they need to serve pages with a valid HTTP status code. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */
description: 'Pages with unsuccessful HTTP status codes may not be indexed properly. ' +
'[Learn more]' +
'(https://developers.google.com/web/tools/lighthouse/audits/successful-http-code).',
'[Learn more](https://web.dev/http-status-code).',
};

const str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings);
Expand Down
3 changes: 1 addition & 2 deletions lighthouse-core/audits/seo/is-crawlable.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ const UIStrings = {
failureTitle: 'Page is blocked from indexing',
/** Description of a Lighthouse audit that tells the user *why* allowing search-engine crawling of their page is beneficial. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */
description: 'Search engines are unable to include your pages in search results ' +
'if they don\'t have permission to crawl them. [Learn ' +
'more](https://developers.google.com/web/tools/lighthouse/audits/indexing).',
'if they don\'t have permission to crawl them. [Learn more](https://web.dev/is-crawable).',
};

const str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings);
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/seo/link-text.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ const UIStrings = {
failureTitle: 'Links do not have descriptive text',
/** Description of a Lighthouse audit that tells the user *why* they need to have descriptive text on the links in their page. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */
description: 'Descriptive link text helps search engines understand your content. ' +
'[Learn more](https://developers.google.com/web/tools/lighthouse/audits/descriptive-link-text).',
'[Learn more](https://web.dev/link-text).',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI the screenshot in this doc is of a Lighthouse error/bug instead of the audit failing

/** [ICU Syntax] Label for the audit identifying the number of links found. "link" here refers to the links in a web page to other web pages. */
displayValue: `{itemCount, plural,
=1 {1 link found}
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/seo/manual/structured-data.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const i18n = require('../../../lib/i18n/i18n.js');

const UIStrings = {
/** Description of a Lighthouse audit that provides detail on the structured data in a page. "Structured data" is a standardized data format on a page that helps a search engine categorize and understand its contents. This description is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */
description: 'Run the [Structured Data Testing Tool](https://search.google.com/structured-data/testing-tool/) and the [Structured Data Linter](http://linter.structured-data.org/) to validate structured data. [Learn more](https://developers.google.com/search/docs/guides/mark-up-content).',
description: 'Run the [Structured Data Testing Tool](https://search.google.com/structured-data/testing-tool/) and the [Structured Data Linter](http://linter.structured-data.org/) to validate structured data. [Learn more](https://web.dev/structured-data).',
/** Title of a Lighthouse audit that prompts users to manually check their page for valid structured data. "Structured data" is a standardized data format on a page that helps a search engine categorize and understand its contents. */
title: 'Structured data is valid',
};
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/seo/meta-description.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const UIStrings = {
/** Description of a Lighthouse audit that tells the user *why* they need to have meta descriptions on their page. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */
description: 'Meta descriptions may be included in search results to concisely summarize ' +
'page content. ' +
'[Learn more](https://developers.google.com/web/tools/lighthouse/audits/description).',
'[Learn more](https://web.dev/meta-description).',
/** Explanatory message stating that there was a failure in an audit caused by the page's meta description text being empty. */
explanation: 'Description text is empty.',
};
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/seo/plugins.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const UIStrings = {
/** Description of a Lighthouse audit that tells the user *why* they need to avoid using browser plugins in their content. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */
description: 'Search engines can\'t index plugin content, and ' +
'many devices restrict plugins or don\'t support them. ' +
'[Learn more](https://developers.google.com/web/tools/lighthouse/audits/plugins).',
'[Learn more](https://web.dev/plugins).',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI the screenshot in this doc is of a Lighthouse error/bug instead of the audit failing

};

const str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings);
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/seo/robots-txt.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const UIStrings = {
failureTitle: 'robots.txt is not valid',
/** Description of a Lighthouse audit that tells the user *why* they need to have a valid robots.txt file. Note: "robots.txt" is a canonical filename and should not be translated. This is displayed after a user expands the section to see more. No character length limits. */
description: 'If your robots.txt file is malformed, crawlers may not be able to understand ' +
'how you want your website to be crawled or indexed.',
'how you want your website to be crawled or indexed. [Learn more](https://web.dev/robots-txt).',
/**
* @description Label for the audit identifying that the robots.txt request has returned a specific HTTP status code. Note: "robots.txt" is a canonical filename and should not be translated.
* @example {500} statusCode
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/seo/tap-targets.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const UIStrings = {
/** Descriptive title of a Lighthouse audit that provides detail on whether tap targets (like buttons and links) on a page are big enough so they can easily be tapped on a mobile device. This descriptive title is shown when tap targets are not easy to tap on. */
failureTitle: 'Tap targets are not sized appropriately',
/** Description of a Lighthouse audit that tells the user why buttons and links need to be big enough and what 'big enough' means. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */
description: 'Interactive elements like buttons and links should be large enough (48x48px), and have enough space around them, to be easy enough to tap without overlapping onto other elements. [Learn more](https://developers.google.com/web/fundamentals/accessibility/accessible-styles#multi-device_responsive_design).',
description: 'Interactive elements like buttons and links should be large enough (48x48px), and have enough space around them, to be easy enough to tap without overlapping onto other elements. [Learn more](https://web.dev/tap-targets).',
/** Label of a table column that identifies tap targets (like buttons and links) that have failed the audit and aren't easy to tap on. */
tapTargetHeader: 'Tap Target',
/** Label of a table column that identifies a tap target (like a link or button) that overlaps with another tap target. */
Expand Down
22 changes: 11 additions & 11 deletions lighthouse-core/lib/i18n/locales/en-US.json
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,7 @@
"message": "Keep request counts low and transfer sizes small"
},
"lighthouse-core/audits/seo/canonical.js | description": {
"message": "Canonical links suggest which URL to show in search results. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/canonical)."
"message": "Canonical links suggest which URL to show in search results. [Learn more](https://web.dev/canonical)."
},
"lighthouse-core/audits/seo/canonical.js | explanationConflict": {
"message": "Multiple conflicting URLs ({urlList})"
Expand All @@ -849,7 +849,7 @@
"message": "Document has a valid `rel=canonical`"
},
"lighthouse-core/audits/seo/font-size.js | description": {
"message": "Font sizes less than 12px are too small to be legible and require mobile visitors to “pinch to zoom” in order to read. Strive to have >60% of page text ≥12px. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/font-sizes)."
"message": "Font sizes less than 12px are too small to be legible and require mobile visitors to “pinch to zoom” in order to read. Strive to have >60% of page text ≥12px. [Learn more](https://web.dev/font-size)."
},
"lighthouse-core/audits/seo/font-size.js | displayValue": {
"message": "{decimalProportion, number, extendedPercent} legible text"
Expand All @@ -867,7 +867,7 @@
"message": "Document uses legible font sizes"
},
"lighthouse-core/audits/seo/hreflang.js | description": {
"message": "hreflang links tell search engines what version of a page they should list in search results for a given language or region. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/hreflang)."
"message": "hreflang links tell search engines what version of a page they should list in search results for a given language or region. [Learn more](https://web.dev/hreflang)."
},
"lighthouse-core/audits/seo/hreflang.js | failureTitle": {
"message": "Document doesn't have a valid `hreflang`"
Expand All @@ -876,7 +876,7 @@
"message": "Document has a valid `hreflang`"
},
"lighthouse-core/audits/seo/http-status-code.js | description": {
"message": "Pages with unsuccessful HTTP status codes may not be indexed properly. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/successful-http-code)."
"message": "Pages with unsuccessful HTTP status codes may not be indexed properly. [Learn more](https://web.dev/http-status-code)."
},
"lighthouse-core/audits/seo/http-status-code.js | failureTitle": {
"message": "Page has unsuccessful HTTP status code"
Expand All @@ -885,7 +885,7 @@
"message": "Page has successful HTTP status code"
},
"lighthouse-core/audits/seo/is-crawlable.js | description": {
"message": "Search engines are unable to include your pages in search results if they don't have permission to crawl them. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/indexing)."
"message": "Search engines are unable to include your pages in search results if they don't have permission to crawl them. [Learn more](https://web.dev/is-crawable)."
},
"lighthouse-core/audits/seo/is-crawlable.js | failureTitle": {
"message": "Page is blocked from indexing"
Expand All @@ -894,7 +894,7 @@
"message": "Page isn’t blocked from indexing"
},
"lighthouse-core/audits/seo/link-text.js | description": {
"message": "Descriptive link text helps search engines understand your content. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/descriptive-link-text)."
"message": "Descriptive link text helps search engines understand your content. [Learn more](https://web.dev/link-text)."
},
"lighthouse-core/audits/seo/link-text.js | displayValue": {
"message": "{itemCount, plural,\n =1 {1 link found}\n other {# links found}\n }"
Expand All @@ -906,13 +906,13 @@
"message": "Links have descriptive text"
},
"lighthouse-core/audits/seo/manual/structured-data.js | description": {
"message": "Run the [Structured Data Testing Tool](https://search.google.com/structured-data/testing-tool/) and the [Structured Data Linter](http://linter.structured-data.org/) to validate structured data. [Learn more](https://developers.google.com/search/docs/guides/mark-up-content)."
"message": "Run the [Structured Data Testing Tool](https://search.google.com/structured-data/testing-tool/) and the [Structured Data Linter](http://linter.structured-data.org/) to validate structured data. [Learn more](https://web.dev/structured-data)."
},
"lighthouse-core/audits/seo/manual/structured-data.js | title": {
"message": "Structured data is valid"
},
"lighthouse-core/audits/seo/meta-description.js | description": {
"message": "Meta descriptions may be included in search results to concisely summarize page content. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/description)."
"message": "Meta descriptions may be included in search results to concisely summarize page content. [Learn more](https://web.dev/meta-description)."
},
"lighthouse-core/audits/seo/meta-description.js | explanation": {
"message": "Description text is empty."
Expand All @@ -924,7 +924,7 @@
"message": "Document has a meta description"
},
"lighthouse-core/audits/seo/plugins.js | description": {
"message": "Search engines can't index plugin content, and many devices restrict plugins or don't support them. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/plugins)."
"message": "Search engines can't index plugin content, and many devices restrict plugins or don't support them. [Learn more](https://web.dev/plugins)."
},
"lighthouse-core/audits/seo/plugins.js | failureTitle": {
"message": "Document uses plugins"
Expand All @@ -933,7 +933,7 @@
"message": "Document avoids plugins"
},
"lighthouse-core/audits/seo/robots-txt.js | description": {
"message": "If your robots.txt file is malformed, crawlers may not be able to understand how you want your website to be crawled or indexed."
"message": "If your robots.txt file is malformed, crawlers may not be able to understand how you want your website to be crawled or indexed. [Learn more](https://web.dev/robots-txt)."
},
"lighthouse-core/audits/seo/robots-txt.js | displayValueHttpBadCode": {
"message": "request for robots.txt returned HTTP status: {statusCode}"
Expand All @@ -951,7 +951,7 @@
"message": "robots.txt is valid"
},
"lighthouse-core/audits/seo/tap-targets.js | description": {
"message": "Interactive elements like buttons and links should be large enough (48x48px), and have enough space around them, to be easy enough to tap without overlapping onto other elements. [Learn more](https://developers.google.com/web/fundamentals/accessibility/accessible-styles#multi-device_responsive_design)."
"message": "Interactive elements like buttons and links should be large enough (48x48px), and have enough space around them, to be easy enough to tap without overlapping onto other elements. [Learn more](https://web.dev/tap-targets)."
},
"lighthouse-core/audits/seo/tap-targets.js | displayValue": {
"message": "{decimalProportion, number, percent} appropriately sized tap targets"
Expand Down
Loading