Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: axe-core@3.3.0 #9343

Merged
merged 3 commits into from
Jul 10, 2019
Merged

deps: axe-core@3.3.0 #9343

merged 3 commits into from
Jul 10, 2019

Conversation

patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented Jul 10, 2019

Summary
Updates axe-core to version just released 2019-07-08.

Notable changes:

  • API for synchronous run might be interesting for us to look into since IIRC there was a lot of time spent in async control passing we don't really need.
  • Some big perf wins
  • A few new rules we might want to add audits for (aria-input-field-label, aria-toggle-field-label)
  • Lots of bug fixes

Related Issues/PRs
closes #9337, see dequelabs/axe-core#1597 (comment)

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adds about 6KB after gzip :(

A few new rules we might want to add audits for (aria-input-field-label, aria-toggle-field-label)

do we need to disable any? (and maybe add them to #7127?)

looks like there's a smoke change needed, too

@patrickhulce
Copy link
Collaborator Author

done done and done.

yeah not sure what we can do about size other than put pressure on axe to trim some fat though :)

@brendankenny
Copy link
Member

yeah not sure what we can do about size other than put pressure on axe to trim some fat though :)

no, not much. Custom axe bundling or something :)

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulirish
Copy link
Member

Some big perf wins

sgtm! on a test URL, i saw axe taking 1350ms before and now 1050ms. sweet

@connorjclark
Copy link
Collaborator

they suggest axe is twice as fast for large pages. hope that's true!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link with nested role text results in error 'Links do not have a discernible name'
5 participants