-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link with nested role text results in error 'Links do not have a discernible name' #9337
Comments
Is this actually different from #9075? From my limited understanding it seems like it's the same root axe issue dequelabs/axe-core#1597 |
It would certainly seem to be related, whether it's the same issue I guess axe can only answer that? I wasn't sure as it gives a different error. I've just asked in dequelabs/axe-core#1597 |
@patrickhulce how to I find out what version of axe Lighthouse is using? dequelabs/axe-core#1597 (comment) |
So interestingly I just ran a Lighthouse (Lighthouse 4.3.1) audit using the 'Audit' tab in the Chrome browser (Version 75.0.3770.100 Official Build 64-bit) and it gives the error 'Links do not have a discernible name' however when I run an 'Audit' using the Lighthouse browser extension (Lighthouse 5.1.0) I do not get that error. I presume Lighthouse 4.3.1 is using a different version of axe to Lighthouse 5.1.0? How do I ensure I'm using the latest version of Lighthouse in the web inspector 'Audit' tab? Which I believe is the recommended way to run this tool? |
The version of Lighthouse in Audits panel of stable Chrome runs a bit behind because of Chrome's release process. To use latest, you can use the CLI ( Not a particularly easy way to tell what version of axe we're using outside of the source. It's on 3.2.2 currently and in 5.1.0. Line 140 in 4c658d2
|
Looks like we need to update to 3.3.0 then! |
Do you have a repro URL for this page @greenc05? |
Thanks @patrickhulce Do I have a repro URL for which page? |
Nevermind I created one with the repro, just curious if the page with the example code you provided was in the wild somewhere :) |
It will be live on Monday! Can send it then if useful. |
When a link has a nested element with
role="text"
(added to stop 'text splitting' in VoiceOver iOS https://axesslab.com/text-splitting/) such as:This causes the following error when running an audit in Lighthouse Accessibility 'Links do not have a discernible name'.
This error should not occur as the link does have a discernible name with the presence of
role="text"
. See related issue: #9075The text was updated successfully, but these errors were encountered: