Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update budget link #8871

Merged
merged 4 commits into from
May 6, 2019
Merged

docs: update budget link #8871

merged 4 commits into from
May 6, 2019

Conversation

paulirish
Copy link
Member

its staged right here now: https://pr-7561-dot-web-central.appspot.com/web/tools/lighthouse/audits/budgets

google/WebFundamentals#7561

but will be landing soon and i wanted to have the link in place by then.

@paulirish paulirish requested a review from exterkamp as a code owner May 6, 2019 04:47
@paulirish paulirish mentioned this pull request May 6, 2019
Closed
67 tasks
brendankenny
brendankenny approved these changes May 6, 2019
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those whitespace changes are your fault from merging #8803 without an update, so I'm glad you're fixing them :P

LGTM. You should probably rebase before landing as #8870 might do funky things to the sample_v2.json auto merge otherwise

(oh, jk, will have to fix the conflict anyways :)

@paulirish paulirish merged commit 4e09c92 into master May 6, 2019
@paulirish paulirish deleted the budgetdoclink branch May 6, 2019 18:58
paulirish added a commit that referenced this pull request May 28, 2019
@paulirish
docs: update budget link (#8871)
1ce32fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@patrickhulce patrickhulce Awaiting requested review from patrickhulce

@exterkamp exterkamp Awaiting requested review from exterkamp

Assignees
No one assigned
Labels
land-when-ci-is-green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulirish @brendankenny