Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update budget link #8871

Merged
merged 4 commits into from
May 6, 2019
Merged

docs: update budget link #8871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7fea185
docs: update budget link
paulirish May 6, 2019
87ca8e7
Merge branch 'master' into budgetdoclink
paulirish May 6, 2019
65b90e3
update json
paulirish May 6, 2019
d7949fe
Merge branch 'master' into budgetdoclink
paulirish May 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lighthouse-core/audits/performance-budget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ const i18n = require('../lib/i18n/i18n.js');
const UIStrings = {
/** Title of a Lighthouse audit that compares the size and quantity of page resources against targets set by the user. These targets are thought of as "performance budgets" because these metrics impact page performance (i.e. how quickly a page loads). */
title: 'Performance budget',
/** Description of a Lighthouse audit where a user sets budgets for the quantity and size of page resources. No character length limits. */
/** Description of a Lighthouse audit where a user sets budgets for the quantity and size of page resources. No character length limits. 'Learn More' becomes link text to additional documentation. */
description: 'Keep the quantity and size of network requests under the targets ' +
'set by the provided performance budget.',
'set by the provided performance budget. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/budgets).',
/** [ICU Syntax] Entry in a data table identifying the number of network requests of a particular type. Count will be a whole number. String should be as short as possible to be able to fit well into the table. */
requestCountOverBudget: `{count, plural,
=1 {1 request}
Expand Down
4 changes: 2 additions & 2 deletions lighthouse-core/audits/resource-summary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ const i18n = require('../lib/i18n/i18n.js');
const UIStrings = {
/** Imperative title of a Lighthouse audit that tells the user to minimize the size and quantity of resources used to load the page. */
title: 'Keep request counts low and transfer sizes small',
/** Description of a Lighthouse audit that tells the user that they can setup a budgets for the quantity and size of page resources. No character length limits. */
/** Description of a Lighthouse audit that tells the user that they can setup a budgets for the quantity and size of page resources. No character length limits. 'Learn More' becomes link text to additional documentation. */
description: 'To set budgets for the quantity and size of page resources,' +
' add a budget.json file.',
' add a budget.json file. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/budgets).',
/** [ICU Syntax] Label for an audit identifying the number of requests and kilobytes used to load the page. */
displayValue: `{requestCount, plural, =1 {1 request} other {# requests}}` +
` • { byteCount, number, bytes } KB`,
Expand Down
8 changes: 4 additions & 4 deletions lighthouse-core/lib/i18n/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,8 +744,8 @@
"description": "Descriptive title of a Lighthouse audit that tells the user the server latencies observed from each origin the page connected to. This is displayed in a list of audit titles that Lighthouse generates."
},
"lighthouse-core/audits/performance-budget.js | description": {
"message": "Keep the quantity and size of network requests under the targets set by the provided performance budget.",
"description": "Description of a Lighthouse audit where a user sets budgets for the quantity and size of page resources. No character length limits."
"message": "Keep the quantity and size of network requests under the targets set by the provided performance budget. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/budgets).",
"description": "Description of a Lighthouse audit where a user sets budgets for the quantity and size of page resources. No character length limits. 'Learn More' becomes link text to additional documentation."
},
"lighthouse-core/audits/performance-budget.js | requestCountOverBudget": {
"message": "{count, plural,\n =1 {1 request}\n other {# requests}\n }",
Expand All @@ -764,8 +764,8 @@
"description": "Imperative title of a Lighthouse audit that tells the user to eliminate the redirects taken through multiple URLs to load the page. This is shown in a list of audits that Lighthouse generates."
},
"lighthouse-core/audits/resource-summary.js | description": {
"message": "To set budgets for the quantity and size of page resources, add a budget.json file.",
"description": "Description of a Lighthouse audit that tells the user that they can setup a budgets for the quantity and size of page resources. No character length limits."
"message": "To set budgets for the quantity and size of page resources, add a budget.json file. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/budgets).",
"description": "Description of a Lighthouse audit that tells the user that they can setup a budgets for the quantity and size of page resources. No character length limits. 'Learn More' becomes link text to additional documentation."
},
"lighthouse-core/audits/resource-summary.js | displayValue": {
"message": "{requestCount, plural, =1 {1 request} other {# requests}} • { byteCount, number, bytes } KB",
Expand Down
4 changes: 2 additions & 2 deletions lighthouse-core/test/results/sample_v2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1276,7 +1276,7 @@
"performance-budget": {
"id": "performance-budget",
"title": "Performance budget",
"description": "Keep the quantity and size of network requests under the targets set by the provided performance budget.",
"description": "Keep the quantity and size of network requests under the targets set by the provided performance budget. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/budgets).",
"score": null,
"scoreDisplayMode": "informative",
"details": {
Expand Down Expand Up @@ -1379,7 +1379,7 @@
"resource-summary": {
"id": "resource-summary",
"title": "Keep request counts low and transfer sizes small",
"description": "To set budgets for the quantity and size of page resources, add a budget.json file.",
"description": "To set budgets for the quantity and size of page resources, add a budget.json file. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/budgets).",
"score": null,
"scoreDisplayMode": "informative",
"displayValue": "18 requests • 157 KB",
Expand Down
72 changes: 36 additions & 36 deletions proto/sample_v2_round_trip.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2032,7 +2032,7 @@
"title": "Prevents users to paste into password fields"
},
"performance-budget": {
"description": "Keep the quantity and size of network requests under the targets set by the provided performance budget.",
"description": "Keep the quantity and size of network requests under the targets set by the provided performance budget. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/budgets).",
"details": {
"headings": [
{
Expand Down Expand Up @@ -2245,7 +2245,7 @@
"title": "Eliminate render-blocking resources"
},
"resource-summary": {
"description": "To set budgets for the quantity and size of page resources, add a budget.json file.",
"description": "To set budgets for the quantity and size of page resources, add a budget.json file. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/budgets).",
"details": {
"headings": [
{
Expand Down Expand Up @@ -2453,51 +2453,51 @@
"details": {
"headings": [
{
"itemType": "node",
"key": "tapTarget",
"itemType": "node",
"key": "tapTarget",
"text": "Tap Target"
},
},
{
"itemType": "text",
"key": "size",
"itemType": "text",
"key": "size",
"text": "Size"
},
},
{
"itemType": "node",
"key": "overlappingTarget",
"itemType": "node",
"key": "overlappingTarget",
"text": "Overlapping Target"
}
],
],
"items": [
{
"height": 18.0,
"overlapScoreRatio": 0.8333333333333334,
"height": 18.0,
"overlapScoreRatio": 0.8333333333333334,
"overlappingTarget": {
"path": "3,HTML,1,BODY,18,BUTTON",
"selector": "body > button.small-button",
"snippet": "<button class=\"small-button\">Do something else</button>",
"path": "3,HTML,1,BODY,18,BUTTON",
"selector": "body > button.small-button",
"snippet": "<button class=\"small-button\">Do something else</button>",
"type": "node"
},
"overlappingTargetScore": 720.0,
"size": "200x18",
},
"overlappingTargetScore": 720.0,
"size": "200x18",
"tapTarget": {
"path": "3,HTML,1,BODY,17,BUTTON",
"selector": "body > button.small-button",
"snippet": "<button class=\"small-button\">Do something</button>",
"path": "3,HTML,1,BODY,17,BUTTON",
"selector": "body > button.small-button",
"snippet": "<button class=\"small-button\">Do something</button>",
"type": "node"
},
"tapTargetScore": 864.0,
},
"tapTargetScore": 864.0,
"width": 200.0
}
],
],
"type": "table"
},
"displayValue": "0% appropriately sized tap targets",
"id": "tap-targets",
"score": 0.0,
"scoreDisplayMode": "binary",
},
"displayValue": "0% appropriately sized tap targets",
"id": "tap-targets",
"score": 0.0,
"scoreDisplayMode": "binary",
"title": "Tap targets are not sized appropriately"
},
},
"td-headers-attr": {
"description": "Screen readers have features to make navigating tables easier. Ensuring `<td>` cells using the `[headers]` attribute only refer to other cells in the same table may improve the experience for screen reader users. [Learn more](https://dequeuniversity.com/rules/axe/3.1/td-headers-attr?application=lighthouse).",
"id": "td-headers-attr",
Expand Down Expand Up @@ -3773,11 +3773,11 @@
"id": "structured-data",
"weight": 0.0
}
],
"description": "These checks ensure that your page is optimized for search engine results ranking. There are additional factors Lighthouse does not check that may affect your search ranking. [Learn more](https://support.google.com/webmasters/answer/35769).",
"id": "seo",
"manualDescription": "Run these additional validators on your site to check additional SEO best practices.",
"score": 0.73,
],
"description": "These checks ensure that your page is optimized for search engine results ranking. There are additional factors Lighthouse does not check that may affect your search ranking. [Learn more](https://support.google.com/webmasters/answer/35769).",
"id": "seo",
"manualDescription": "Run these additional validators on your site to check additional SEO best practices.",
"score": 0.73,
"title": "SEO"
}
},
Expand Down