Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(proto): assert libprotoc version #8863

Merged
merged 1 commit into from
May 5, 2019
Merged

misc(proto): assert libprotoc version #8863

merged 1 commit into from
May 5, 2019

Conversation

connorjclark
Copy link
Collaborator

Prevents churn from unintended changes caused by version differences. See #8857 (comment)

@connorjclark connorjclark mentioned this pull request May 5, 2019
Merged
exterkamp
exterkamp approved these changes May 5, 2019
View reviewed changes
Copy link
Member

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea, anything to make proto more consistent.

@paulirish paulirish changed the title proto: assert tool version misc(proto): assert libprotoc version May 5, 2019
@paulirish paulirish merged commit 86c8a0f into master May 5, 2019
@paulirish paulirish deleted the proto-ver-check branch May 5, 2019 19:39
@brendankenny
Copy link
Member

I'm like 90% sure this is wrong, btw :)

@paulirish paulirish restored the proto-ver-check branch May 5, 2019 19:57
@brendankenny brendankenny deleted the proto-ver-check branch May 5, 2019 19:58
@brendankenny brendankenny mentioned this pull request May 5, 2019
Merged
paulirish pushed a commit that referenced this pull request May 28, 2019
@connorjclark @paulirish
misc(proto): assert libprotoc version (#8863)
a47ab62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exterkamp exterkamp exterkamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@connorjclark @brendankenny @exterkamp @paulirish