misc(proto): require protobuf 3.7.1, add stricter audit details test #8867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
May 5, 2019
package.json
Outdated
| @@ -59,7 +59,7 @@ | |||
| "ultradumbBenchmark": "./lighthouse-core/scripts/benchmark.js", | |||
| "mixed-content": "./lighthouse-cli/index.js --chrome-flags='--headless' --preset=mixed-content", | |||
| "minify-latest-run": "./lighthouse-core/scripts/lantern/minify-trace.js ./latest-run/defaultPass.trace.json ./latest-run/defaultPass.trace.min.json && ./lighthouse-core/scripts/lantern/minify-devtoolslog.js ./latest-run/defaultPass.devtoolslog.json ./latest-run/defaultPass.devtoolslog.min.json", | |||
| "compile-proto": "[ \"$(protoc --version)\" == 'libprotoc 3.6.1' ] && protoc --python_out=./ ./proto/lighthouse-result.proto && mv ./proto/*_pb2.py ./proto/scripts || (echo \"❌ Install protobuf to compile the proto file.\" && false)", | |||
| "compile-proto": "[ \"$(protoc --version)\" == 'libprotoc 3.7.1' ] && protoc --python_out=./ ./proto/lighthouse-result.proto && mv ./proto/*_pb2.py ./proto/scripts || (echo \"❌ Install protobuf to compile the proto file.\" && false)", | |||
There was a problem hiding this comment.
@paulirish sounds like we don't want the version test anymore, though? Probably good cause future versions wouldn't match and I'm not sure if the version check will work cross platform (we don't run update:sample-json on appveyor...)
paulirish
approved these changes
May 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #8863 and #8857 (comment)
Something was fixed between protobuf 3.6.1 and 3.7.1 that handled the
details.summarytype when the value was just an empty{}. 3.6.1 round tripped it asnull, 3.7.1 correctly round trips it as{}.The round trip test wasn't catching the issue because
{}was thesummaryexpectation and{}matches basically everything withtoMatchObject. The round trip is good enough for audit results now that we can just do the deep, stricttoEqualinstead.