extension(taburl): extension Error: couldn't resolve current tab #5591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Jun 29, 2018
There was a problem hiding this comment.
what a pro! awesome job hunting this down @wardpeet 💯 🥇 👍 🎉
| background.loadSettings().then(settings => { | ||
| onGenerateReportButtonClick(background, settings); | ||
| }); | ||
| if (!background.isRunning()) { |
There was a problem hiding this comment.
micronit: if (background.isRunning()) return; either here or onGenerateReportButtonClick matches a bit more with what I might expect, but awesome 🔍
|
I used a boolean instead. The smoketest didn't work out so no test :( |
This was referenced May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
bugfix
When you run the extension and hit enter immediately afterwards, lighthouse tries to start again which will start on about:blank and fails as it can't get an url from the tab.
Related Issues/PRs
https://github.com/GoogleChrome/lighthouse/issues?q=is%3Aissue+Error%3A+Couldn%27t+resolve+current+tab+is%3Aclosed