Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️bug: Extension Error: Couldn't resolve current tab. Check your URL, reload, and tr #5668

Open
consultantjay opened this issue Jul 15, 2018 · 5 comments

Comments

@consultantjay
Copy link

Lighthouse Version: 3.0.2
Lighthouse Commit: ff7d162
Chrome Version: 67.0.3396.99
Initial URL: http://localhost:8081/app
Error Message: Couldn't resolve current tab. Check your URL, reload, and try again. Found 1 tab(s) with id(s) [211].
Stack Trace:

Error: Couldn't resolve current tab. Check your URL, reload, and try again. Found 1 tab(s) with id(s) [211].
    at Object.chrome.tabs.query.tabs [as callback] (chrome-extension://blipmdconlkpinefehnmjammfjpmpbjk/scripts/lighthouse-ext-background.js:17347:15)
    at safeCallbackApply (extensions::uncaught_exception_handler:27:15)
    at handleResponse (extensions::sendRequest:67:7)
@patrickhulce
Copy link
Collaborator

@consultantjay could you provide any additional information on how you ran into this issue? Did rerunning solve it?

cc @wardpeet so #5591 didn't fix it 😢

@devtools-bot
Copy link

Howdy chief! Appreciate you filing this bug. 👏

We think this is the same root issue as #5668. So, we'll automatically mark this as a duplicate. Thanks!
🤖 Beep beep boop.

@wardpeet
Copy link
Collaborator

After some debugging I might have found the root cause.

When the extension is ran and an error is thrown without the feedback button (see below) the extension is still open and when you run lighthouse again it won't be able to resolve the url. It looks like tabs.query doesn't return the url anymore. The real reason is that we lose access to the tab when we move to about:blank.

the bug: (this is taken on the resolved feedback branch #5872)
lighthouse-resolve-tab

how to easily mimic this bug without running lighthouse. This shows why about:blank is the bad guy:

  1. make sure to inspect the extension popup so we the extension view stays open.
  2. run the commands from the gif
    lighthouse-about-blank-optimized

why without the feedback button?
There is a bug when the feedback button is showing we the extension just crashes as it can't find the feedback button because of a class mismatch. (#5872)

@brendankenny brendankenny changed the title Extension Error: Couldn't resolve current tab. Check your URL, reload, and tr ☂️bug: Extension Error: Couldn't resolve current tab. Check your URL, reload, and tr Apr 25, 2019
@connorjclark
Copy link
Collaborator

Would be fixed by #8690 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants
@paulirish @brendankenny @wardpeet @patrickhulce @connorjclark @consultantjay @devtools-bot and others