Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(meta-tag-gatherers): meta tag search should be case-insensitive #3729

Merged
merged 2 commits into from
Nov 6, 2017
Merged

core(meta-tag-gatherers): meta tag search should be case-insensitive #3729

merged 2 commits into from
Nov 6, 2017

Conversation

kdzwinel
Copy link
Collaborator

@kdzwinel kdzwinel commented Nov 2, 2017

screen shot 2017-11-02 at 22 00 20

patrickhulce
patrickhulce suggested changes Nov 2, 2017
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! want to change one of the smoke tests to catch this failure case?

@kdzwinel
Copy link
Collaborator Author

kdzwinel commented Nov 2, 2017

@patrickhulce good point! I've updated one of my previous tests (and somehow pulled @brendankenny into this - sorry!).

patrickhulce
patrickhulce approved these changes Nov 2, 2017
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch @kdzwinel thanks for fixing!

@patrickhulce patrickhulce merged commit 45d8537 into GoogleChrome:master Nov 6, 2017
christhompson pushed a commit to christhompson/lighthouse that referenced this pull request Nov 28, 2017
@kdzwinel @christhompson
core(meta-tag-gatherers): meta tag search should be case-insensitive (G…
8d941a8 
…oogleChrome#3729)

* Metatag search should be case-insensitive

* Modify SEO smoke test to test case-insenstive meta tags
@dependencies dependencies bot mentioned this pull request Dec 17, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@paulirish paulirish Awaiting requested review from paulirish

@brendankenny brendankenny Awaiting requested review from brendankenny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdzwinel @patrickhulce