Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(meta-tag-gatherers): meta tag search should be case-insensitive #3729

Merged
merged 2 commits into from
Nov 6, 2017
Merged

core(meta-tag-gatherers): meta tag search should be case-insensitive #3729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
151ed1b
Metatag search should be case-insensitive
kdzwinel Nov 2, 2017
1617363
Modify SEO smoke test to test case-insenstive meta tags
kdzwinel Nov 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lighthouse-cli/test/fixtures/seo/seo-tester.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<title>SEO audit tester</title>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=1.0">
<meta name="description" content="The premiere destination for testing your SEO audit gathering">
<meta name="Description" content="The premiere destination for testing your SEO audit gathering">
</head>
<body>
<h1>SEO</h1>
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/gather/gatherers/seo/meta-description.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class MetaDescription extends Gatherer {
afterPass(options) {
const driver = options.driver;

return driver.querySelector('head meta[name="description"]')
return driver.querySelector('head meta[name="description" i]')
.then(node => node && node.getAttribute('content'));
}
}
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/gather/gatherers/theme-color.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class ThemeColor extends Gatherer {
afterPass(options) {
const driver = options.driver;

return driver.querySelector('head meta[name="theme-color"]')
return driver.querySelector('head meta[name="theme-color" i]')
.then(node => node && node.getAttribute('content'));
}
}
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/gather/gatherers/viewport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class Viewport extends Gatherer {
afterPass(options) {
const driver = options.driver;

return driver.querySelector('head meta[name="viewport"]')
return driver.querySelector('head meta[name="viewport" i]')
.then(node => node && node.getAttribute('content'));
}
}
Expand Down