fix: don't remove obsolete files when synth raises exception #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
bcoe
reviewed
Aug 6, 2020
| @@ -216,6 +216,28 @@ def test_nothing_happens_when_disabled(source_tree, preserve_track_obsolete_file | |||
| assert os.path.exists("code/c") | |||
|
|
|||
|
|
|||
| def test_nothing_happens_when_exception(source_tree, preserve_track_obsolete_file_flag): | |||
There was a problem hiding this comment.
in the case of @google-cloud/logging what state would this leave us in once the run finishes, will we move towards being in a health up-to-date state with the metadata?
There was a problem hiding this comment.
It will leave the old synth.metadata without updating it at all.
chingor13
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.