Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): add nox session to sort python imports #1402

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Apr 2, 2022

Fixes #1401

I tested the changes using the following commands after cloning synthtool

git checkout add-nox-session-to-sort-python-imports
docker build -f docker/owlbot/python/Dockerfile -t testformat . 

Once the docker image was built, I ran the following commands in the root of python-analytics-admin and python-secret-manager which have samples.

docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo testformat

I tested the changes in the following repositories:
googleapis/python-analytics-admin#208
googleapis/python-secret-manager#280

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 2, 2022
@parthea parthea changed the title [do not merge] chore(python): add nox session to sort python imports [chore(python): add nox session to sort python imports Apr 4, 2022
@parthea parthea changed the title [do not merge] chore(python): add nox session to sort python imports [chore(python): add nox session to sort python imports Apr 4, 2022
@parthea parthea changed the title [chore(python): add nox session to sort python imports python): add nox session to sort python imports Apr 4, 2022
@parthea parthea changed the title python): add nox session to sort python imports chore(python): add nox session to sort python imports Apr 4, 2022
@parthea parthea self-assigned this Apr 6, 2022
@parthea parthea marked this pull request as ready for review April 19, 2022 17:43
@parthea parthea requested a review from a team April 19, 2022 17:43
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 19, 2022
@parthea parthea merged commit 1b71c10 into master Apr 20, 2022
@parthea parthea deleted the add-nox-session-to-sort-python-imports branch April 20, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR(python): update owlbot_main() to automatically sort python imports using isort with --fss option
2 participants