Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make generate_index_ts() deterministic #1104

Merged
merged 1 commit into from
May 27, 2021
Merged

fix: make generate_index_ts() deterministic #1104

merged 1 commit into from
May 27, 2021

Conversation

SurferJeffAtGoogle
Copy link
Contributor

Fixes #1103

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 27, 2021
@tmatsuo
Copy link
Contributor

tmatsuo commented May 27, 2021

Ok to merge. Can we eventually have an integration test which make sure it's deterministic if it makes sense.

@SurferJeffAtGoogle SurferJeffAtGoogle merged commit c3e41da into googleapis:master May 27, 2021
@SurferJeffAtGoogle SurferJeffAtGoogle deleted the fix1103 branch May 27, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

@tmatsuo tmatsuo tmatsuo approved these changes

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

common_templates.node_library() is not deterministic
4 participants
@SurferJeffAtGoogle @tmatsuo @chingor13 @bcoe