Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly referencing "tests" in the dependency testing section? #1755

Closed
chalmerlowe opened this issue Jan 26, 2023 · 1 comment
Closed
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chalmerlowe
Copy link
Contributor

chalmerlowe commented Jan 26, 2023

I appears that this section is incorrectly including a local package, but not installing it as a local package.
Note that tests is properly installed earlier in the code (using editable mode) so the line in question is not required.

This came up during some troubleshooting in Google's library python-bigquery-sqlalchemy
In the noxfile.py for python-bigquery-sqlalchemy under the variable SYSTEM_TEST_EXTRAS we include only one item: [tests]

In the session.install() function calls in the prerelease_deps function, we install tests in editable mode from a local package. But we then attempt to reinstall the same local package without using the local editable mode, it results in a test failure. I will be submitting a PR to remove the SYSTEM_TEST_EXTRAS line.

    session.install("-e", ".[all, tests, tracing]")
    unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
    session.install(*unit_deps_all)
    system_deps_all = (
        SYSTEM_TEST_STANDARD_DEPENDENCIES
        + SYSTEM_TEST_EXTERNAL_DEPENDENCIES
        + SYSTEM_TEST_EXTRAS

https://github.com/googleapis/synthtool/blob/71a4369253ed12bd4138f8fc68dc8d54b52fe736/synthtool/gcp/templates/python_library/noxfile.py.j2#LL418C9-L418C9

chalmerlowe added a commit that referenced this issue Jan 26, 2023
parthea pushed a commit that referenced this issue Jan 30, 2023
Remove duplicate reference to packages during install

Proposed fix to issue identified in #1755
@chingor13 chingor13 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 13, 2023
@chingor13
Copy link
Contributor

Fixed in #1756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

4 participants