Incorrectly referencing "tests" in the dependency testing section? #1755
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
I appears that this section is incorrectly including a local package, but not installing it as a local package.
Note that
tests
is properly installed earlier in the code (using editable mode) so the line in question is not required.This came up during some troubleshooting in Google's library
python-bigquery-sqlalchemy
In the
noxfile.py
forpython-bigquery-sqlalchemy
under the variableSYSTEM_TEST_EXTRAS
we include only one item:[tests]
In the
session.install()
function calls in theprerelease_deps
function, we installtests
in editable mode from a local package. But we then attempt to reinstall the same local package without using the local editable mode, it results in a test failure. I will be submitting a PR to remove the SYSTEM_TEST_EXTRAS line.https://github.com/googleapis/synthtool/blob/71a4369253ed12bd4138f8fc68dc8d54b52fe736/synthtool/gcp/templates/python_library/noxfile.py.j2#LL418C9-L418C9
The text was updated successfully, but these errors were encountered: