feat(java8): lambda-ize single-method anon classes [ggj] #815

miraleung · 2021-08-03T18:20:52Z

No description provided.

…nto dev/lambda-anon

codecov · 2021-08-03T18:31:15Z

Codecov Report

Merging #815 (2ecbad5) into master (c98c0c7) will decrease coverage by 0.01%.
The diff coverage is 96.42%.

@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
- Coverage   91.32%   91.31%   -0.02%     
==========================================
  Files         140      140              
  Lines       15050    15017      -33     
  Branches     1086     1086              
==========================================
- Hits        13745    13713      -32     
+ Misses       1009     1008       -1     
  Partials      296      296

Impacted Files	Coverage Δ
...api/generator/engine/ast/MethodInvocationExpr.java	`100.00% <ø> (ø)`
...ic/composer/common/ServiceClientClassComposer.java	`98.69% <80.00%> (+0.07%)`	⬆️
...mmon/AbstractServiceStubSettingsClassComposer.java	`97.16% <100.00%> (ø)`
...ic/composer/grpc/GrpcServiceStubClassComposer.java	`97.87% <100.00%> (-0.11%)`	⬇️
...ic/composer/grpc/MockServiceImplClassComposer.java	`99.53% <100.00%> (ø)`
...omposer/rest/HttpJsonServiceStubClassComposer.java	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c98c0c7...2ecbad5. Read the comment docs.

vam-google

Very nice to have lambdas! Though this will mean I will have some painful marge conflicts, but I think it is worth it.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [zipp](https://github.com/jaraco/zipp) | `==3.6.0` -> `==3.8.1` | [![age](https://badges.renovateapi.com/packages/pypi/zipp/3.8.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/zipp/3.8.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/zipp/3.8.1/compatibility-slim/3.6.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/zipp/3.8.1/confidence-slim/3.6.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>jaraco/zipp</summary> ### [`v3.8.1`](https://github.com/jaraco/zipp/blob/HEAD/CHANGES.rst#v381) [Compare Source](https://github.com/jaraco/zipp/compare/v3.8.0...v3.8.1) \====== Refreshed packaging. Enrolled with Tidelift. ### [`v3.8.0`](https://github.com/jaraco/zipp/blob/HEAD/CHANGES.rst#v380) [Compare Source](https://github.com/jaraco/zipp/compare/v3.7.0...v3.8.0) \====== Removed compatibility code. ### [`v3.7.0`](https://github.com/jaraco/zipp/blob/HEAD/CHANGES.rst#v370) [Compare Source](https://github.com/jaraco/zipp/compare/v3.6.0...v3.7.0) \====== Require Python 3.7 or later. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-shared-dependencies).

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.grpc:grpc-bom](https://github.com/grpc/grpc-java) | `1.45.1` -> `1.46.0` | [![age](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.46.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.46.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.46.0/compatibility-slim/1.45.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.46.0/confidence-slim/1.45.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc/grpc-java</summary> ### [`v1.46.0`](https://github.com/grpc/grpc-java/releases/v1.46.0) [Compare Source](https://github.com/grpc/grpc-java/compare/v1.45.1...v1.46.0) ##### Bug Fixes - netty: Fixed incompatibility with Netty 4.1.75.Final that caused COMPRESSION_ERROR ([#9004](https://github.com/grpc/grpc-java/issues/9004)) - xds: Fix LBs blindly propagating control plane errors ([#9012](https://github.com/grpc/grpc-java/issues/9012)). This change forces the use of UNAVAILABLE for any xDS communication failures, which otherwise could greatly confuse an application. This is essentially a continuation of the fix in 1.45.0 for XdsNameResolver, but for other similar cases - xds: Fix ring_hash reconnecting behavior. Previously a TRANSIENT_FAILURE subchannel would remain failed forever - xds: Fix ring_hash defeating priority’s failover connection timeout. [grpc/proposal#296](https://github.com/grpc/proposal/issues/296) - binder: Work around an Android Intent bug for consistent AndroidComponentAndress hashCode() and equals() ([#9061](https://github.com/grpc/grpc-java/issues/9061)) - binder: Fix deadlock when using process-local Binder ([#8987](https://github.com/grpc/grpc-java/issues/8987)). Process-local binder has a different threading model than normal FLAG_ONEWAY, so this case is now detected and the FLAG_ONEWAY threading model is emulated - okhttp: Removed dead code in io.grpc.okhttp.internal.Util. This should have no impact except for static code analysis. This code was never used and was from the process of forking okhttp. It calculated things like MD5 which can trigger security scanners ([#9071](https://github.com/grpc/grpc-java/issues/9071)) ##### Behavior Changes - java_grpc_library.bzl: Pass use_default_shell_env = True for protoc ([#8984](https://github.com/grpc/grpc-java/issues/8984)). This allows using MinGW on Windows - xds: Unconditionally apply backoff on ADS and LDS stream recreation. Previously if a message had been received on the stream no backoff wait would be performed. This limits QPS to a buggy server to 1 QPS, instead of a closed loop - xds: Skip Routes within VirtualHosts whose RouteAction has no cluster_specifier. This probably means the control plane is using a cluster_specifier field unknown/unsupported by gRPC. The control plane can repeat the Route with a different cluster_specifier for compatibility with older clients - xds: Support `xds.config.resource-in-sotw` client capability. Resources wrapped in a `io.envoyproxy.envoy.service.discovery.v3.Resource` message are now supported ([#8997](https://github.com/grpc/grpc-java/issues/8997)) ##### New Features - gcp-observability: A new experimental module for improving visibility into gRPC workloads. Initially supports logging RPCs to Google Cloud Logging - grpclb: Support setting initial fallback timeout by service config ([#8980](https://github.com/grpc/grpc-java/issues/8980)) ##### Dependencies - PerfMark bumped to 0.25.0 ([#8948](https://github.com/grpc/grpc-java/issues/8948)) - okhttp: the okhttp dependency is now compile only ([#8971](https://github.com/grpc/grpc-java/issues/8971)). Okhttp’s internal HTTP/2 implementation was forked inside grpc-okhttp a long time ago, but there had been a few stray internal classes that had not been forked but should have been. That has now been fixed in preparation for OkHttp 3/4 support. Compile-only may cause a runtime failure for code using reflection on OkHttpChannelBuilder; add a dependency on okhttp 2.7.4 to resolve - bom: Removed protoc-gen-grpc-java from the BOM, as the classifier was confusing and it provided no value ([#9020](https://github.com/grpc/grpc-java/issues/9020)) ##### Acknowledgements [@jesseschalken](https://github.com/jesseschalken) [@kluever](https://github.com/kluever) [@beatrausch](https://github.com/beatrausch) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).

🤖 I have created a release *beep* *boop* --- ## [2.7.0](googleapis/java-core@v2.6.1...v2.7.0) (2022-05-18) ### Features * **java:** remove native-image-support module ([#820](googleapis/java-core#820)) ([b827e0a](googleapis/java-core@b827e0a)) * next release from main branch is 2.7.0 ([#807](googleapis/java-core#807)) ([2145212](googleapis/java-core@2145212)) ### Bug Fixes * remove native-image-support module from version.txt ([#822](googleapis/java-core#822)) ([8285eee](googleapis/java-core@8285eee)) ### Dependencies * update dependency com.google.api-client:google-api-client-bom to v1.34.1 ([#823](googleapis/java-core#823)) ([58aac09](googleapis/java-core@58aac09)) * update dependency com.google.api:api-common to v2.2.0 ([#827](googleapis/java-core#827)) ([fa4a5db](googleapis/java-core@fa4a5db)) * update dependency com.google.api:gax-bom to v2.17.0 ([#826](googleapis/java-core#826)) ([d1d886d](googleapis/java-core@d1d886d)) * update dependency com.google.api:gax-bom to v2.18.0 ([#829](googleapis/java-core#829)) ([355dd4a](googleapis/java-core@355dd4a)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.2 ([#805](googleapis/java-core#805)) ([c5b4893](googleapis/java-core@c5b4893)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.3 ([#814](googleapis/java-core#814)) ([9621659](googleapis/java-core@9621659)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.4 ([#825](googleapis/java-core#825)) ([8f907db](googleapis/java-core@8f907db)) * update dependency com.google.auth:google-auth-library-bom to v1.7.0 ([#828](googleapis/java-core#828)) ([0e53f0c](googleapis/java-core@0e53f0c)) * update dependency com.google.cloud:native-image-support to v0.14.0 ([#824](googleapis/java-core#824)) ([bbeb567](googleapis/java-core@bbeb567)) * update dependency com.google.errorprone:error_prone_annotations to v2.13.1 ([#806](googleapis/java-core#806)) ([c4d3e17](googleapis/java-core@c4d3e17)) * update dependency com.google.http-client:google-http-client-bom to v1.41.8 ([#821](googleapis/java-core#821)) ([8c747e1](googleapis/java-core@8c747e1)) * update dependency com.google.protobuf:protobuf-bom to v3.20.1 ([#813](googleapis/java-core#813)) ([f259b41](googleapis/java-core@f259b41)) * update dependency io.grpc:grpc-bom to v1.46.0 ([#815](googleapis/java-core#815)) ([2dc7507](googleapis/java-core@2dc7507)) * update opencensus.version to v0.31.1 ([#819](googleapis/java-core#819)) ([96982b0](googleapis/java-core@96982b0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

miraleung added 2 commits July 20, 2021 14:06

feat: Lambda-ize single-method anon classes

272a04c

Merge branch 'master' of github.com:googleapis/gapic-generator-java i…

2ecbad5

…nto dev/lambda-anon

miraleung requested a review from a team as a code owner August 3, 2021 18:20

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 3, 2021

miraleung requested review from Neenu1995 and vam-google August 3, 2021 18:21

Neenu1995 approved these changes Aug 3, 2021

View reviewed changes

vam-google approved these changes Aug 3, 2021

View reviewed changes

miraleung merged commit 19b661c into master Aug 3, 2021

miraleung deleted the dev/lambda-anon branch August 3, 2021 18:45

miraleung mentioned this pull request Sep 15, 2021

[ggj] Replace anonymous classes with lambdas in generated code #791

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(java8): lambda-ize single-method anon classes [ggj] #815

feat(java8): lambda-ize single-method anon classes [ggj] #815

miraleung commented Aug 3, 2021

codecov bot commented Aug 3, 2021

vam-google left a comment

feat(java8): lambda-ize single-method anon classes [ggj] #815

feat(java8): lambda-ize single-method anon classes [ggj] #815

Conversation

miraleung commented Aug 3, 2021

codecov bot commented Aug 3, 2021

Codecov Report

vam-google left a comment

Choose a reason for hiding this comment