feat(gax): add API key authentication to ClientSettings #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
…dentials are provided
product-auto-label
bot
added
size: m
product-auto-label
bot
added
size: l
product-auto-label
bot
added
size: m
ldetmer
commented
Sep 19, 2024
| @@ -175,9 +176,19 @@ public static ClientContext create(StubSettings settings) throws IOException { | |||
| // A valid EndpointContext should have been created in the StubSettings | |||
| EndpointContext endpointContext = settings.getEndpointContext(); | |||
| String endpoint = endpointContext.resolvedEndpoint(); | |||
| String apiKey = settings.getApiKey(); | |||
| Credentials credentials = settings.getCredentialsProvider().getCredentials(); | |||
| if (apiKey != null && credentials != null) { | |||
There was a problem hiding this comment.
I added logic here to handle null check snd setting credentials (instead of in builder) as I thought it would be more discoverable/debuggable here since the rest of credential logic lives here
ldetmer
commented
Sep 19, 2024
| throw new IllegalArgumentException("The GDC-H API audience string is not a valid URI", ex); | ||
| } | ||
| credentials = ((GdchCredentials) credentials).createWithGdchAudience(gdchAudienceUri); | ||
| credentials = getGdchCredentials(settingsGdchApiAudience, endpoint, credentials); |
There was a problem hiding this comment.
created helper method for readability, no change to logic
ldetmer
changed the title
ldetmer
changed the title
ldetmer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow gax client libraries to authenticate using API key via setApiKey method exposed from ClientSettings.
Tested using LanguageServiceSettings