Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Cop: add test failure log to issues #513

Closed
ace-n opened this issue May 1, 2020 · 2 comments · Fixed by #519
Closed

Build Cop: add test failure log to issues #513

ace-n opened this issue May 1, 2020 · 2 comments · Fixed by #519
Assignees
Labels
bot: flakybot type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@ace-n
Copy link

ace-n commented May 1, 2020

As title. 🙂

If this log is not included, it can cause spurious (and practically un-debuggable! 😱) failures like this one if the log cannot be retrieved in some other way.

@ace-n ace-n changed the title Add test failure log to build cop issues Add test failure log to build-cop-bot generated issues May 1, 2020
@tbpg tbpg changed the title Add test failure log to build-cop-bot generated issues Build Cop: add test failure log to issues May 1, 2020
@tbpg tbpg added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label May 1, 2020
@tbpg tbpg self-assigned this May 1, 2020
@tbpg
Copy link
Contributor

tbpg commented May 1, 2020

Thanks! One concern to keep in mind is that failure logs can be long. So, we might want to wrap the log in a collapsible element. Emails would still be long, but I think that's OK.

@tbpg
Copy link
Contributor

tbpg commented May 1, 2020

Thank you for the feature request! Feel free to file another issue if there is anything else we can improve (or this doesn't work as expected). :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: flakybot type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants