Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functions/tips: should call a GCP API failed #1758

Closed
flaky-bot bot opened this issue Apr 29, 2020 · 4 comments
Closed

functions/tips: should call a GCP API failed #1758

flaky-bot bot opened this issue Apr 29, 2020 · 4 comments
Assignees
Labels
api: cloudfunctions Issues related to the Cloud Run functions API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Apr 29, 2020

This test failed!

To configure my behavior, see the Build Cop Bot documentation.

If I'm commenting on this issue too often, add the buildcop: quiet label and
I will stop commenting.


commit: da03d9b
buildURL: Build Status, Sponge
status: failed

@flaky-bot flaky-bot bot added buildcop: issue priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 29, 2020
@fhinkel fhinkel added the api: cloudfunctions Issues related to the Cloud Run functions API. label Apr 29, 2020
@ace-n
Copy link
Contributor

ace-n commented Apr 29, 2020

This failure seems unrelated to the labeled commit. I suspect it's a flaky test.

More concerningly however, there are no test logs to be read (it seems like the "output test results to XML" functionality failed, or the logs were otherwise swallowed), so debugging this failure is essentially impossible.

@fhinkel what should we do here? Re-run the test and mark closed if it passes, or try to investigate why the failure occurred? (@tbpg it might help if the build-cop bot added a copy of the failure logs to the issue itself.)

@flaky-bot
Copy link
Author

flaky-bot bot commented Apr 30, 2020

Test passed for commit 774ee22 (Build Status, Sponge)! Closing this issue.

@flaky-bot flaky-bot bot closed this as completed Apr 30, 2020
@tbpg
Copy link
Contributor

tbpg commented Apr 30, 2020

@ace-n that idea has come up a couple times -- I like it. Mind filing a feature request at https://github.com/googleapis/repo-automation-bots/issues/new/choose?

@tbpg
Copy link
Contributor

tbpg commented May 1, 2020

Closing the loop here, the bot will now include the failure log in comments. :) Thank you for the feature request!

Edit: now* include

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudfunctions Issues related to the Cloud Run functions API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants