Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass an array of change log section options to the node releaser #538

Merged
merged 2 commits into from
Sep 5, 2020

Conversation

lholmquist
Copy link
Contributor

Fixes #537

@lholmquist lholmquist requested a review from a team as a code owner September 3, 2020 20:59
@google-cla
Copy link

google-cla bot commented Sep 3, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 3, 2020
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #538 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #538      +/-   ##
==========================================
- Coverage   82.25%   82.24%   -0.02%     
==========================================
  Files          42       42              
  Lines        4819     4827       +8     
  Branches      414      387      -27     
==========================================
+ Hits         3964     3970       +6     
- Misses        854      856       +2     
  Partials        1        1              
Impacted Files Coverage Δ
src/releasers/python.ts 39.20% <0.00%> (ø)
src/releasers/ruby.ts 36.20% <0.00%> (-0.32%) ⬇️
src/releasers/terraform-module.ts 32.67% <0.00%> (-0.33%) ⬇️
src/release-pr.ts 90.81% <100.00%> (+0.12%) ⬆️
src/releasers/node.ts 93.47% <100.00%> (+0.04%) ⬆️
src/releasers/simple.ts 92.78% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39fbf06...e6f5280. Read the comment docs.

@lholmquist
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 3, 2020
@bcoe bcoe changed the title feat: This adds the ability to pass an array of change log section options to the node releaser feat: pass an array of change log section options to the node releaser Sep 3, 2020
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding this for the main languages we advertise in the action:

simple, terraform-module, ruby, python, node?

I would just double check that none of them override the value already, if they do we can just make the override the default.

Thank you for the contribution 👏

@bcoe
Copy link
Contributor

bcoe commented Sep 5, 2020

@lholmquist thank you for the contributions 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass in change log section Options
2 participants