-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pass an array of change log section options to the node releaser #538
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #538 +/- ##
==========================================
- Coverage 82.25% 82.24% -0.02%
==========================================
Files 42 42
Lines 4819 4827 +8
Branches 414 387 -27
==========================================
+ Hits 3964 3970 +6
- Misses 854 856 +2
Partials 1 1
Continue to review full report at Codecov.
|
@googlebot I signed it! |
24cc864
to
447877c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind adding this for the main languages we advertise in the action:
simple
, terraform-module
, ruby
, python
, node
?
I would just double check that none of them override the value already, if they do we can just make the override the default.
Thank you for the contribution 👏
718e606
to
cd6646e
Compare
cd6646e
to
e6f5280
Compare
@lholmquist thank you for the contributions 👌 |
Fixes #537