Setting changelog-type to "github" results in a new release on any type of commit

[bodgit]

Environment details

• OS: LInux
• Node.js version: n/a
• npm version: n/a
• release-please version: Using v3 of the release-please-action so whatever version is used there.

Steps to reproduce

See #2078 for the background. I found that with any type of commit/merged PR, release-please was generating a new release, even for just chore commits, which I thought shouldn't happen.

My release-please-config.json was originally this:

{
  "changelog-type": "github",
  "packages": {
    ".": {
      "release-type": "go",
      "extra-files": [
        "README.md",
        "main.go"
      ]
    }
  }
}

I had added the changelog-type setting to see what the difference was in the generated changelog, removing it so my release-please-config.json looks like this:

{
  "packages": {
    ".": {
      "release-type": "go",
      "extra-files": [
        "README.md",
        "main.go"
      ]
    }
  }
}

And now normal behaviour is restored.

[stutommi]

I'm puzzled by the same issue, I can see that with the configuration (below), seems like atleast commits starting with "chore:" and "docs:" (and probably all the others aswell, haven't tested) result in release-please action generating patch bumps:

name: release-please
on:
  push:
    branches:
      - main

permissions:
  contents: write
  pull-requests: write

jobs:
  release-please:
    runs-on: ubuntu-latest
    steps:
      - uses: google-github-actions/release-please-action@v3
        with:
          token: ${{ secrets.MY_TOKEN }}
          release-type: go
          bump-minor-pre-major: true
          changelog-types: >
            [
              { "type": "build", "section": "Build System", "hidden": false },
              { "type": "ci", "section": "Continuous Integration", "hidden": false },
              { "type": "chore", "section": "Miscellaneous Chores", "hidden": false },
              { "type": "docs", "section": "Documentation", "hidden": false },
              { "type": "feat", "section": "Features", "hidden": false },
              { "type": "fix", "section": "Bug Fixes", "hidden": false },
              { "type": "perf", "section": "Performance Improvements", "hidden": false },
              { "type": "revert", "section": "Reverts", "hidden": false },
              { "type": "refactor", "section": "Code Refactoring", "hidden": false },
              { "type": "style", "section": "Styles", "hidden": false },
              { "type": "test", "section": "Tests", "hidden": false }
            ]

[stutommi]

I dug through the code how changelog-types swim in the code logic, and found out that it seems to be currently working as expected. Every type that is not marked as hidden will be treated as conventional commit and all of them will be treated as patch upgrade at the minimum.

Sorry @bodgit, I didn't have time to check changelog-type and how that goes. Just stating here that my confusion seems to be expected behavior (although don't really know if it's considered good design or well documented).

[chingor13]

If you use the GitHub changelog type, it defers building the changelog to GitHub's logic which ignores any changelog-types configuration.