-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spanner_v1/trace: allow option for extended tracing which will allow recording the SQL statement if provided #1171
Labels
api: spanner
Issues related to the googleapis/python-spanner API.
Comments
product-auto-label
bot
added
the
api: spanner
Issues related to the googleapis/python-spanner API.
label
Jul 24, 2024
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Jul 26, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Also added in an option toggled by environment variable ENABLE_EXTENDED_TRACING=true which allows spans to be annotated with the SQL statement keyed by "db.statement" Fixes googleapis#1170 Fixes googleapis#1171 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Jul 26, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Also added in an option toggled by environment variable ENABLE_EXTENDED_TRACING=true which allows spans to be annotated with the SQL statement keyed by "db.statement" Fixes googleapis#1170 Fixes googleapis#1171 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Jul 29, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Also added in an option toggled by environment variable ENABLE_EXTENDED_TRACING=true which allows spans to be annotated with the SQL statement keyed by "db.statement" Fixes googleapis#1170 Fixes googleapis#1171 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Jul 30, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Also added in an option toggled by environment variable ENABLE_EXTENDED_TRACING=true which allows spans to be annotated with the SQL statement keyed by "db.statement" Fixes googleapis#1170 Fixes googleapis#1171 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Jul 31, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Also added in an option toggled by environment variable ENABLE_EXTENDED_TRACING=true which allows spans to be annotated with the SQL statement keyed by "db.statement" Fixes googleapis#1170 Fixes googleapis#1171 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Aug 9, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Also added in an option toggled by environment variable ENABLE_EXTENDED_TRACING=true which allows spans to be annotated with the SQL statement keyed by "db.statement" Fixes googleapis#1170 Fixes googleapis#1171 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Aug 19, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Also added in an option toggled by environment variable ENABLE_EXTENDED_TRACING=true which allows spans to be annotated with the SQL statement keyed by "db.statement" Fixes googleapis#1170 Fixes googleapis#1171 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Sep 10, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Also added in an option toggled by environment variable ENABLE_EXTENDED_TRACING=true which allows spans to be annotated with the SQL statement keyed by "db.statement" Fixes googleapis#1170 Fixes googleapis#1171 Fixes googleapis#1173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Part of modernized tracing is that it becomes pretty useful for customers to investigate slow queries when observing traces; customers would like to opt-in to ensure that this library records their SQL statements in their traces where applicable e.g. if they've explicitly opted into having their spans annotated with the SQL statement; explicitly because some SQL statement might have personally identifiable information (PII) and leak sensitive data out.
I am going to work on this issue myself.
The text was updated successfully, but these errors were encountered: