Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'Client.from_service_account_info' factory #54

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 10, 2020

Closes #8.

@tseaver tseaver requested a review from a team as a code owner December 10, 2020 18:46
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2020
@tseaver
Copy link
Contributor Author

tseaver commented Jun 11, 2021

Note: some of these changes are spurious, introduced by my use of pre-commit, which blackened the source at the time. I have opened #98 to track the fact that we don't use black in this repository.

Update: I have rebased against master and removed the spurious black-generated changes.

@tseaver tseaver requested a review from tswast June 11, 2021 20:47
@tseaver tseaver force-pushed the 8-add-client-factory-from-dict branch from 8fe5882 to 00bd98d Compare June 11, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create client from service account stored in string
2 participants