Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: silence non-relevant system test warnings #1068

Merged
merged 1 commit into from
Nov 18, 2021
Merged

cleanup: silence non-relevant system test warnings #1068

merged 1 commit into from
Nov 18, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Nov 17, 2021

Fixes #1060.

Instead of fighting with geo data and how to correctly compute the area, I opted for the same fix we used in #973.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut requested review from tswast and a team November 17, 2021 10:22
@plamut plamut requested a review from a team as a code owner November 17, 2021 10:22
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 17, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 17, 2021
loferris
loferris approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@loferris loferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plamut plamut merged commit 1b5dc5c into googleapis:main Nov 18, 2021
@plamut plamut deleted the iss-1060 branch November 18, 2021 07:23
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@plamut @abdelmegahedgoogle
cleanup: silence non-relevant system test warnings (googleapis#1068)
fb71292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@loferris loferris loferris approved these changes

@tswast tswast Awaiting requested review from tswast

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix warnings caused by library code when running system tests
3 participants
@plamut @tseaver @loferris