Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking Change] Remove google.cloud.bigquery_v2 directory and related code generation #814

Closed
6 tasks done
tswast opened this issue Jul 26, 2021 · 1 comment
Closed
6 tasks done
Assignees
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. semver: major Hint for users that this is an API breaking change. type: process A process-related concern. May include testing, release, or the like.

Comments

@tswast
Copy link
Contributor

tswast commented Jul 26, 2021

The google.cloud.bigquery_v2 modules are frequently out-of-date. This primarily affect the usability of BigQuery ML.

Since BigQuery is a REST API, protobuf changes must be synced manually in internal code repo before they can be published to https://github.com/googleapis/googleapis

In the years since we first introduced google.cloud.bigquery_v2, we've seen that BigQuery ML adds model stats and model types much more frequently than the protobuf changes are actually published.

We've worked around this by:

Solution

  • Remove google.cloud.bigquery_v2 modules
  • Update owlbot config to stop generating "client"
  • In the BigQuery ML classes, whereever we were returning protobuf object, return the JSON-parsed API response, instead.
    • Complex types become dictionaries.
    • Enums become strings.
  • In the routines logic, create manual wrappers and enums where needed.

Supersedes #319

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jul 26, 2021
@tswast tswast added the type: process A process-related concern. May include testing, release, or the like. label Jul 26, 2021
@plamut plamut added the semver: major Hint for users that this is an API breaking change. label Jul 27, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 27, 2021
Closes #814.

The first preview. Still need to address Model types, disable code generation, BigQuery ML classes...

**PR checklist:**
- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)
@plamut
Copy link
Contributor

plamut commented Oct 1, 2021

Done in #855. The issue was probably not closed automatically, because the PR was merged into the v3 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. semver: major Hint for users that this is an API breaking change. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

2 participants