Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Support SQLAlchemy 2.0, drop support for 1.x #918

Closed
wants to merge 0 commits into from
Closed

feat!: Support SQLAlchemy 2.0, drop support for 1.x #918

wants to merge 0 commits into from

Conversation

sharoonthomas
Copy link
Contributor

This patch makes this library backward incompatible for versions of SQLAlchemy < 2.0.

Fixes #510

@sharoonthomas sharoonthomas requested review from a team as code owners October 26, 2023 19:18
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Oct 26, 2023
@sharoonthomas
Copy link
Contributor Author

@alvarowolfx is it normal for test suite to take this long?

@shollyman shollyman requested review from chalmerlowe, Linchin and nayaknishant and removed request for alvarowolfx October 26, 2023 20:09
@Linchin Linchin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2023
@tswast tswast changed the title Add support for SQLAlchemy 2.0 feat!: Support SQLAlchemy 2.0, drop support for 1.x Oct 26, 2023
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2023
@sharoonthomas
Copy link
Contributor Author

Looks like the build is failing because of conflicting constraints. I can move all to 2.0. Would you like me to do that?

@tswast
Copy link
Collaborator

tswast commented Oct 27, 2023

Yes. Constraints should match the minimum version we advertise in setup.py. Thanks.

@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 27, 2023
@tswast
Copy link
Collaborator

tswast commented Oct 27, 2023

I pushed a commit to this branch that should address the constraints issue, I believe.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 27, 2023
@sharoonthomas
Copy link
Contributor Author

LMK if there is anything I can help with

@nayaknishant
Copy link
Contributor

nayaknishant commented Oct 27, 2023 •
edited
Loading

thanks for this PR @sharoonthomas! Let me look into why the the tests are failing. We'll need them to pass before we can submit the PR (unless they're failing because of the depreciation of 1.x).

@nayaknishant nayaknishant added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 31, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 31, 2023
@nayaknishant nayaknishant added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 31, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 31, 2023
@product-auto-label product-auto-label bot added size: u Pull request is empty. and removed size: l Pull request size is large. labels Oct 31, 2023
@nayaknishant
Copy link
Contributor

Hi @sharoonthomas, I was trying to force push some changes to owlbot.py and this closed the PR. My apologizes.

With your permission and after you sign our Contributor Licencse Agreement (https://cla.developers.google.com) if you haven't already, do you think I'd be able to create a new pull request based from fb57dee? Thanks.

@sharoonthomas
Copy link
Contributor Author

sharoonthomas commented Oct 31, 2023 •
edited
Loading

Hi @sharoonthomas, I was trying to force push some changes to owlbot.py and this closed the PR. My apologizes.

No worries

With your permission and after you sign our Contributor Licencse Agreement (https://cla.developers.google.com) if you haven't already, do you think I'd be able to create a new pull request based from fb57dee? Thanks.

Already signed and can open a new PR based on fb57dee

@nayaknishant
Copy link
Contributor

Thanks @sharoonthomas!

@sharoonthomas
Copy link
Contributor Author

Opened #920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe

@Linchin Linchin Awaiting requested review from Linchin

@nayaknishant nayaknishant Awaiting requested review from nayaknishant

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: u Pull request is empty.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQLAlchemy 2.0 support
5 participants
@sharoonthomas @tswast @nayaknishant @Linchin @yoshi-kokoro