fix(types): assert in typescript 3.7 (#1198)

* fix(types): assert in typescript 3.7 * npm run fix
googleapis · May 20, 2020 · d5aa8b7 · d5aa8b7
1 parent 621e6f4
commit d5aa8b7
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/test/bucket.ts b/test/bucket.ts
@@ -281,7 +281,9 @@ describe('Bucket', () => {
       });
 
       const bucket = new Bucket(storageInstance, BUCKET_NAME);
-      assert(bucket instanceof ServiceObject);
+      // Using assert.strictEqual instead of assert to prevent
+      // coercing of types.
+      assert.strictEqual(bucket instanceof ServiceObject, true);
 
       const calledWith = bucket.calledWith_[0];
 
@@ -2069,8 +2071,8 @@ describe('Bucket', () => {
       FakeServiceObject.prototype.request = ((
         reqOpts: DecorateRequestOptions
       ) => {
-        assert.strictEqual(reqOpts.qs, options.qs);
         assert.strictEqual(reqOpts.qs.userProject, USER_PROJECT);
+        assert.strictEqual(reqOpts.qs, options.qs);
         done();
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
       }) as any;

diff --git a/test/channel.ts b/test/channel.ts
@@ -68,7 +68,9 @@ describe('Channel', () => {
 
   describe('initialization', () => {
     it('should inherit from ServiceObject', () => {
-      assert(channel instanceof ServiceObject);
+      // Using assert.strictEqual instead of assert to prevent
+      // coercing of types.
+      assert.strictEqual(channel instanceof ServiceObject, true);
 
       const calledWith = channel.calledWith_[0];
 

diff --git a/test/file.ts b/test/file.ts
@@ -264,7 +264,9 @@ describe('File', () => {
     });
 
     it('should inherit from ServiceObject', () => {
-      assert(file instanceof ServiceObject);
+      // Using assert.strictEqual instead of assert to prevent
+      // coercing of types.
+      assert.strictEqual(file instanceof ServiceObject, true);
 
       const calledWith = file.calledWith_[0];
 

diff --git a/test/index.ts b/test/index.ts
@@ -123,7 +123,9 @@ describe('Storage', () => {
     });
 
     it('should inherit from Service', () => {
-      assert(storage instanceof Service);
+      // Using assert.strictEqual instead of assert to prevent
+      // coercing of types.
+      assert.strictEqual(storage instanceof Service, true);
 
       const calledWith = storage.calledWith_[0];