Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

fix: make request optional in all cases #19

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ jobs:
- run: rm -rf node_modules
- run: npm install
- run: npm test
env:
MOCHA_THROW_DEPRECATION: false
windows:
runs-on: windows-latest
steps:
Expand All @@ -33,6 +35,8 @@ jobs:
node-version: 14
- run: npm install
- run: npm test
env:
MOCHA_THROW_DEPRECATION: false
lint:
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 1 addition & 1 deletion .jsdoc.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ module.exports = {
copyright: 'Copyright 2021 Google LLC',
includeDate: false,
sourceFiles: false,
systemName: '@google-cloud/serviceusage',
systemName: '@google-cloud/service-usage',
theme: 'lumen',
default: {
outputSourceFiles: false
Expand Down
24 changes: 12 additions & 12 deletions src/v1/service_usage_client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ export class ServiceUsageClient {
// -- Service calls --
// -------------------
getService(
request: protos.google.api.serviceusage.v1.IGetServiceRequest,
request?: protos.google.api.serviceusage.v1.IGetServiceRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -404,7 +404,7 @@ export class ServiceUsageClient {
* const [response] = await client.getService(request);
*/
getService(
request: protos.google.api.serviceusage.v1.IGetServiceRequest,
request?: protos.google.api.serviceusage.v1.IGetServiceRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -445,7 +445,7 @@ export class ServiceUsageClient {
return this.innerApiCalls.getService(request, options, callback);
}
batchGetServices(
request: protos.google.api.serviceusage.v1.IBatchGetServicesRequest,
request?: protos.google.api.serviceusage.v1.IBatchGetServicesRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -505,7 +505,7 @@ export class ServiceUsageClient {
* const [response] = await client.batchGetServices(request);
*/
batchGetServices(
request: protos.google.api.serviceusage.v1.IBatchGetServicesRequest,
request?: protos.google.api.serviceusage.v1.IBatchGetServicesRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -549,7 +549,7 @@ export class ServiceUsageClient {
}

enableService(
request: protos.google.api.serviceusage.v1.IEnableServiceRequest,
request?: protos.google.api.serviceusage.v1.IEnableServiceRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -615,7 +615,7 @@ export class ServiceUsageClient {
* const [response] = await operation.promise();
*/
enableService(
request: protos.google.api.serviceusage.v1.IEnableServiceRequest,
request?: protos.google.api.serviceusage.v1.IEnableServiceRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -700,7 +700,7 @@ export class ServiceUsageClient {
>;
}
disableService(
request: protos.google.api.serviceusage.v1.IDisableServiceRequest,
request?: protos.google.api.serviceusage.v1.IDisableServiceRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -776,7 +776,7 @@ export class ServiceUsageClient {
* const [response] = await operation.promise();
*/
disableService(
request: protos.google.api.serviceusage.v1.IDisableServiceRequest,
request?: protos.google.api.serviceusage.v1.IDisableServiceRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -861,7 +861,7 @@ export class ServiceUsageClient {
>;
}
batchEnableServices(
request: protos.google.api.serviceusage.v1.IBatchEnableServicesRequest,
request?: protos.google.api.serviceusage.v1.IBatchEnableServicesRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -936,7 +936,7 @@ export class ServiceUsageClient {
* const [response] = await operation.promise();
*/
batchEnableServices(
request: protos.google.api.serviceusage.v1.IBatchEnableServicesRequest,
request?: protos.google.api.serviceusage.v1.IBatchEnableServicesRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -1021,7 +1021,7 @@ export class ServiceUsageClient {
>;
}
listServices(
request: protos.google.api.serviceusage.v1.IListServicesRequest,
request?: protos.google.api.serviceusage.v1.IListServicesRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -1097,7 +1097,7 @@ export class ServiceUsageClient {
* for more details and examples.
*/
listServices(
request: protos.google.api.serviceusage.v1.IListServicesRequest,
request?: protos.google.api.serviceusage.v1.IListServicesRequest,
optionsOrCallback?:
| CallOptions
| PaginationCallback<
Expand Down
Loading