Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update documentation for 31 day subscription message retention #1965

Merged
merged 6 commits into from
Sep 17, 2024
Merged

docs: update documentation for 31 day subscription message retention #1965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd27800
docs: update documentation for 31 day subscription message retention
gcf-owl-bot[bot] Sep 16, 2024
2aa7eb7
debug: printf debugging to inspect owlbot process
feywind Sep 17, 2024
4682793
debug: more debug printf
feywind Sep 17, 2024
eb1c480
build: ignore owl-bot-staging during gts fix
feywind Sep 17, 2024
5e180b7
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Sep 17, 2024
ec55e07
debug: remove debug logs
feywind Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/.nyc_output
/docs/
/out/
**/build/
/build/
system-test/secrets.js
system-test/*key.json
*.lock
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"prelint": "cd samples; npm link ../; npm install",
"precompile": "gts clean",
"typeless": "npx typeless-sample-bot --outputpath samples --targets samples --recursive",
"posttypeless": "cd samples; npm i; cd ..; npm run fix"
"posttypeless": "cd samples && npm i && cd .. && npm run fix"
},
"dependencies": {
"@google-cloud/paginator": "^5.0.0",
Expand Down
2 changes: 1 addition & 1 deletion protos/google/pubsub/v1/pubsub.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,7 +837,7 @@ message Subscription {
// backlog, from the moment a message is published. If `retain_acked_messages`
// is true, then this also configures the retention of acknowledged messages,
// and thus configures how far back in time a `Seek` can be done. Defaults to
// 7 days. Cannot be more than 7 days or less than 10 minutes.
// 7 days. Cannot be more than 31 days or less than 10 minutes.
google.protobuf.Duration message_retention_duration = 8
[(google.api.field_behavior) = OPTIONAL];

Expand Down
2 changes: 1 addition & 1 deletion src/v1/subscriber_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ export class SubscriberClient {
* backlog, from the moment a message is published. If `retain_acked_messages`
* is true, then this also configures the retention of acknowledged messages,
* and thus configures how far back in time a `Seek` can be done. Defaults to
* 7 days. Cannot be more than 7 days or less than 10 minutes.
* 7 days. Cannot be more than 31 days or less than 10 minutes.
* @param {number[]} [request.labels]
* Optional. See [Creating and managing
* labels](https://cloud.google.com/pubsub/docs/labels).
Expand Down
Loading