Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docs for system test #772

Merged
merged 5 commits into from
Oct 3, 2019
Merged

docs: update docs for system test #772

merged 5 commits into from
Oct 3, 2019

Conversation

thebrianchen
Copy link

@thebrianchen thebrianchen commented Oct 1, 2019

pls look sebastian

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 1, 2019
@thebrianchen thebrianchen changed the title docs: Update docs for system test docs: update docs for system test Oct 1, 2019
@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #772 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #772   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files          20       20           
  Lines        2236     2236           
  Branches      467      467           
=======================================
  Hits         2157     2157           
  Misses         24       24           
  Partials       55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c89c5...3ec9331. Read the comment docs.

CONTRIBUTING.md Outdated
@@ -52,4 +52,13 @@ accept your pull requests.

npm run fix

1. Run backend tests:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge this with the previous test section and differentiate between "unit" and "system" tests (rather than backend).

@schmidt-sebastian schmidt-sebastian added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2019
@thebrianchen thebrianchen merged commit 39adabb into master Oct 3, 2019
@thebrianchen thebrianchen deleted the bc/system-docs branch October 3, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants