undo my careless

googleapis · Oct 2, 2019 · 580f7b2 · 580f7b2
1 parent 012897c
commit 580f7b2
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 9 deletions.
diff --git a/dev/src/convert.ts b/dev/src/convert.ts
@@ -94,10 +94,8 @@ export function timestampFromJson(
  */
 function bytesFromJson(bytesValue: string | Uint8Array): Uint8Array {
   if (typeof bytesValue === 'string') {
-    console.error('string bytesfromjson');
     return Buffer.from(bytesValue, 'base64');
   } else {
-    console.error('NOT string bytesfromjson');
     return bytesValue;
   }
 }
@@ -147,7 +145,6 @@ export function detectValueType(proto: ProtobufJsValue): string {
     detectedValues.push('geoPointValue');
   }
   if (proto.bytesValue !== undefined) {
-    console.error('DETECTEDVALUE', proto.bytesValue);
     detectedValues.push('bytesValue');
   }
 
@@ -177,7 +174,6 @@ export function valueFromJson(fieldValue: api.IValue): api.IValue {
         timestampValue: timestampFromJson(fieldValue.timestampValue!),
       };
     case 'bytesValue':
-      console.error('valuefromjson', fieldValue.bytesValue);
       return {
         bytesValue: bytesFromJson(fieldValue.bytesValue!),
       };

diff --git a/dev/src/serializer.ts b/dev/src/serializer.ts
@@ -143,7 +143,6 @@ export class Serializer {
     }
 
     if (val instanceof Buffer || val instanceof Uint8Array) {
-      console.error('encoder', val);
       return {
         bytesValue: val,
       };
@@ -254,7 +253,6 @@ export class Serializer {
         return GeoPoint.fromProto(proto.geoPointValue!);
       }
       case 'bytesValue': {
-        console.error('bytesValue', proto.bytesValue);
         return proto.bytesValue;
       }
       default: {

diff --git a/dev/system-test/firestore.ts b/dev/system-test/firestore.ts
@@ -246,8 +246,7 @@ describe('DocumentReference class', () => {
       });
   });
 
-  it.only('has set() method', () => {
-    setLogFunction(console.log);
+  it('has set() method', () => {
     const allSupportedTypesObject = {
       stringValue: 'a',
       trueValue: true,
@@ -267,7 +266,7 @@ describe('DocumentReference class', () => {
       nilValue: null,
       geoPointValue: new GeoPoint(50.1430847, -122.947778),
       zeroGeoPointValue: new GeoPoint(0, 0),
-      bytesValue: Buffer.alloc(2)
+      bytesValue: Buffer.from([0x01, 0x02]),
     };
     const ref = randomCol.doc('doc');
     return ref