feat: Deprecate format specific row_count field in Read API
#249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
PiperOrigin-RevId: 429331987 Source-Link: googleapis/googleapis@4b2bd26 Source-Link: googleapis/googleapis-gen@fa17f03 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmExN2YwM2I1YWU5NjMxNmNkMDJmMjk5N2YyZmQxMTk2ZTAzNGU1ZSJ9
trusted-contributions-gcf
bot
added
kokoro:force-run
product-auto-label
bot
added
the
api: bigquerystorage
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
…andwritten libraries PiperOrigin-RevId: 429395631 Source-Link: googleapis/googleapis@84594b3 Source-Link: googleapis/googleapis-gen@ed74f97 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWQ3NGY5NzBmZDgyOTE0ODc0ZTZiMjdiMDQ3NjNjZmE2NmJhZmU5YiJ9
gcf-owl-bot
bot
changed the title
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
sofisl
approved these changes
Feb 18, 2022
yoshi-kokoro
removed
the
kokoro:force-run
tmatsuo
approved these changes
Mar 16, 2022
tmatsuo
added
the
automerge
|
The samples test fails with @summer-ji-eng Does it ring a bell? |
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
PiperOrigin-RevId: 438434001 Source-Link: googleapis/googleapis@727f08b Source-Link: googleapis/googleapis-gen@2d62ab0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmQ2MmFiMGQzZDY1MGI3YWJhNGVjNWU1YTk2ZGQ4Y2RiYWU4OWZiNyJ9
gcf-owl-bot
bot
changed the title
row_count field in Read API
trusted-contributions-gcf
bot
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
bot
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
The error is coming from gRPC service. gax take the option bypass to the service and didn't modify the header. And I tried in different version of gax, it comes the same error. So I think it is worth to contact the API service team. Maybe @steffnay. Do you have any idea? |
3 tasks
trusted-contributions-gcf
bot
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 30, 2022
🤖 I have created a release *beep* *boop* --- ## [3.0.0](v2.8.0...v3.0.0) (2022-06-29) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#272) ### Features * Deprecate format specific `row_count` field in Read API ([#249](#249)) ([fb8acf1](fb8acf1)) ### Bug Fixes * fixes for dynamic routing and streaming descriptors ([#274](#274)) ([4271ea0](4271ea0)) * Modify client lib retry policy for CreateWriteStream with longer backoff, more error code and longer overall time ([#279](#279)) ([849cc23](849cc23)) ### Build System * update library to use Node 12 ([#272](#272)) ([5e774e6](5e774e6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl
pushed a commit
to googleapis/google-cloud-node
that referenced
this pull request
Nov 11, 2022
🤖 I have created a release *beep* *boop* --- ## [3.0.0](googleapis/nodejs-bigquery-storage@v2.8.0...v3.0.0) (2022-06-29) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#272) ### Features * Deprecate format specific `row_count` field in Read API ([#249](googleapis/nodejs-bigquery-storage#249)) ([fb8acf1](googleapis/nodejs-bigquery-storage@fb8acf1)) ### Bug Fixes * fixes for dynamic routing and streaming descriptors ([#274](googleapis/nodejs-bigquery-storage#274)) ([4271ea0](googleapis/nodejs-bigquery-storage@4271ea0)) * Modify client lib retry policy for CreateWriteStream with longer backoff, more error code and longer overall time ([#279](googleapis/nodejs-bigquery-storage#279)) ([849cc23](googleapis/nodejs-bigquery-storage@849cc23)) ### Build System * update library to use Node 12 ([#272](googleapis/nodejs-bigquery-storage#272)) ([5e774e6](googleapis/nodejs-bigquery-storage@5e774e6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 438434001
Source-Link: googleapis/googleapis@727f08b
Source-Link: https://github.com/googleapis/googleapis-gen/commit/2d62ab0d3d650b7aba4ec5e5a96dd8cdbae89fb7
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmQ2MmFiMGQzZDY1MGI3YWJhNGVjNWU1YTk2ZGQ4Y2RiYWU4OWZiNyJ9
chore: update v2.14.2 gapic-generator-typescript
Committer: @summer-ji-eng
PiperOrigin-RevId: 434859890
Source-Link: googleapis/googleapis@bc2432d
Source-Link: https://github.com/googleapis/googleapis-gen/commit/930b673103e92523f8cfed38decd7d3afae8ebe7
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTMwYjY3MzEwM2U5MjUyM2Y4Y2ZlZDM4ZGVjZDdkM2FmYWU4ZWJlNyJ9
chore: update v2.14.1 gapic-generator-typescript
Committer: @summer-ji-eng
PiperOrigin-RevId: 433031262
Source-Link: googleapis/googleapis@2a55d13
Source-Link: https://github.com/googleapis/googleapis-gen/commit/2fce3893ae9da47763e0872c4a3a87d9ff78771f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmZjZTM4OTNhZTlkYTQ3NzYzZTA4NzJjNGEzYTg3ZDlmZjc4NzcxZiJ9
docs: improve documentation for write client
feat: update default timeout/retry information
feat: update parent annotation for BatchCommitWriteStreamsRequest
feat: expose additional StorageError enum values
PiperOrigin-RevId: 431973595
Source-Link: googleapis/googleapis@25d691b
Source-Link: https://github.com/googleapis/googleapis-gen/commit/0ca21879ae3136a2d71fa824b49dfaf8a0ae0f2e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGNhMjE4NzlhZTMxMzZhMmQ3MWZhODI0YjQ5ZGZhZjhhMGFlMGYyZSJ9
feat: add trace_id for Read API
PiperOrigin-RevId: 429809867
Source-Link: googleapis/googleapis@6052603
Source-Link: https://github.com/googleapis/googleapis-gen/commit/840dd14c91a0ec66d9bd1a028d01b5fd029ca02e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODQwZGQxNGM5MWEwZWM2NmQ5YmQxYTAyOGQwMWI1ZmQwMjljYTAyZSJ9
docs(samples): include metadata file, add exclusions for samples to handwritten libraries
PiperOrigin-RevId: 429395631
Source-Link: googleapis/googleapis@84594b3
Source-Link: https://github.com/googleapis/googleapis-gen/commit/ed74f970fd82914874e6b27b04763cfa66bafe9b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWQ3NGY5NzBmZDgyOTE0ODc0ZTZiMjdiMDQ3NjNjZmE2NmJhZmU5YiJ9
fix!: remove bigquery.readonly auth scope
PiperOrigin-RevId: 429331987
Source-Link: googleapis/googleapis@4b2bd26
Source-Link: https://github.com/googleapis/googleapis-gen/commit/fa17f03b5ae96316cd02f2997f2fd1196e034e5e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmExN2YwM2I1YWU5NjMxNmNkMDJmMjk5N2YyZmQxMTk2ZTAzNGU1ZSJ9