Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix broken sample tests #2578

Merged
merged 2 commits into from
Jun 13, 2024
Merged

chore: Fix broken sample tests #2578

merged 2 commits into from
Jun 13, 2024

Conversation

sydney-munro
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Jun 6, 2024
@sydney-munro sydney-munro requested a review from a team as a code owner June 6, 2024 19:50
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Jun 6, 2024
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner June 7, 2024 17:29
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jun 7, 2024
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. size: s Pull request size is small. and removed size: s Pull request size is small. size: xs Pull request size is extra small. labels Jun 11, 2024
@sydney-munro sydney-munro added the owlbot:ignore instruct owl-bot to ignore a PR label Jun 11, 2024
@sydney-munro
chore: Fix broken sample tests
ee3cb58 
log exception if thrown in cleanup buckets

Revert "chore: Fix broken sample tests"

This reverts commit 1c94407.

adding some more logging to clean buckets

adding more logging

add logs as prints

add print logging to remote storage helper

more print

removing clean

Adding some lines back

remove lines
@sydney-munro sydney-munro changed the title TEST DO NOT REVIEW chore: Fix broken sample tests chore: Fix broken sample tests Jun 12, 2024
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Jun 12, 2024
@sydney-munro sydney-munro merged commit adc14b9 into main Jun 13, 2024
22 checks passed
@sydney-munro sydney-munro deleted the fix-sample-tests branch June 13, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Assignees

@bourgeoisor bourgeoisor

Labels
api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR samples Issues that are directly related to samples. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sydney-munro @BenWhitehead @bourgeoisor