fix: update GrpcStorageImpl.createFrom(BlobInfo, Path) to use RewindableContent #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenWhitehead
added
do not merge
product-auto-label
bot
added
size: l
frankyn
approved these changes
Jul 13, 2023
BenWhitehead
force-pushed
the
blob-write-channel-v2
branch
from
a1a01f8
to
5cc8745
Compare
BenWhitehead
force-pushed
the
grpc-createFrom-smarter
branch
from
3db650a
to
1cb8340
Compare
BenWhitehead
force-pushed
the
grpc-createFrom-smarter
branch
3 times, most recently
from
a2b8fda
to
770b5bf
Compare
BenWhitehead
removed
the
do not merge
…bleContent With the introduction of RewindableContent, we can now upload an entire file in a single WriteObjectRequest stream. * chore: rename RewindableHttpContent -> RewindableContent
BenWhitehead
force-pushed
the
grpc-createFrom-smarter
branch
from
770b5bf
to
af24360
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of RewindableContent, we can now upload an entire file in a single WriteObjectRequest stream.