Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed beta api annotation for ordering keys #1094

Merged
merged 2 commits into from
Apr 20, 2022
Merged

fix: removed beta api annotation for ordering keys #1094

merged 2 commits into from
Apr 20, 2022

Conversation

mmicatka
Copy link
Contributor

@mmicatka mmicatka commented Apr 20, 2022 •
edited
Loading

Removed BetaApi annotation for ordering keys.

Fixes #1048 ☕️

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/java-pubsub API. labels Apr 20, 2022
@mmicatka mmicatka marked this pull request as ready for review April 20, 2022 18:00
@mmicatka mmicatka requested a review from a team as a code owner April 20, 2022 18:00
anguillanneuf
anguillanneuf approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Mike.

@mmicatka mmicatka added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 20, 2022
@anguillanneuf anguillanneuf added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 20, 2022
@mmicatka mmicatka requested a review from a team as a code owner April 20, 2022 18:14
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 20, 2022
@kamalaboulhosn kamalaboulhosn merged commit 3f140fb into googleapis:main Apr 20, 2022
@release-please release-please bot mentioned this pull request Apr 20, 2022
Merged
@mmicatka mmicatka deleted the removing_beta_api_annotation_for_ordering_keys branch July 29, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove @BetaApi decorator for ordering
4 participants
@mmicatka @anguillanneuf @kamalaboulhosn @yoshi-kokoro