Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @BetaApi decorator for ordering #1048

Closed
anguillanneuf opened this issue Mar 8, 2022 · 4 comments · Fixed by #1094
Closed

Remove @BetaApi decorator for ordering #1048

anguillanneuf opened this issue Mar 8, 2022 · 4 comments · Fixed by #1094
Assignees
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. type: cleanup An internal cleanup or hygiene concern.

Comments

@anguillanneuf
Copy link
Contributor

anguillanneuf commented Mar 8, 2022

Some APIs for ordering are still tagged as @BetaApi but should be removed now?

@BetaApi("Ordering is not yet fully supported and requires special project enablements.")
public void resumePublish(String key) {

@BetaApi("Ordering is not yet fully supported and requires special project enablements.")
public Builder setEnableMessageOrdering(boolean enableMessageOrdering) {

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Mar 8, 2022
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Mar 9, 2022
@meredithslota meredithslota added type: cleanup An internal cleanup or hygiene concern. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Mar 14, 2022
@mmicatka
Copy link
Contributor

Cleaned up. Closing issue.

@hongalex
Copy link
Member

Strangely enough I still see this. Can we keep this open until these decorators are fully removed?

@mmicatka
Copy link
Contributor

mmicatka commented Apr 20, 2022

I mistakenly thought that I had cleaned this up previously.

Just put a PR together to fix this (linked above). Will close after the PR is merged in.

@mmicatka
Copy link
Contributor

Merged PR that removes this annotation. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants