Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handling of superclass generic type parameters #1323

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eranl
Copy link
Contributor

@eranl eranl commented Jun 10, 2023

Enhance generic type resolution, so that no actual type arguments are lost.

For backward compatibility, current lenient behavior of generic collection fields is preserved, unless the new @StrictCollectionTypes annotation is used. A few of the new unit tests verify this lenient behavior. These tests pass with and without this change.

Fixes #1313 ☕️

@eranl eranl requested a review from a team as a code owner June 10, 2023 21:45
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: firestore Issues related to the googleapis/java-firestore API. labels Jun 10, 2023
@eranl
Copy link
Contributor Author

eranl commented Sep 16, 2024

@tom-andersen, @milaGGL, can you please take a look at this PR? I'm happy to rebase it onto current main if you are ready for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/java-firestore API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actual types passed to generic POJO super classes and to generic collection fields are ignored
2 participants