Deprecate plusForSpace #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@elharo could you verify which google projects are using this? I'd prefer not having customers start seeing deprecation warnings that we didn't prepare for first. |
|
Most usages of this should be in our own libraries; e.g. in java-storage. This client is rarely called directly by third party code, so I don't expect a lot of deprecation warnings in customer builds. |
frankyn
approved these changes
Jan 25, 2020
clundin25
pushed a commit
to clundin25/google-http-java-client
that referenced
this pull request
Aug 11, 2022
* feat: add workforce support to ADC with pluggable auth * feat: document workforce identity federation
clundin25
pushed a commit
to clundin25/google-http-java-client
that referenced
this pull request
Aug 11, 2022
🤖 I have created a release *beep* *boop* --- ## [1.10.0](googleapis/google-auth-library-java@v1.9.0...v1.10.0) (2022-08-05) ### Features * workforce identity federation for pluggable auth ([googleapis#959](googleapis/google-auth-library-java#959)) ([7f2c535](googleapis/google-auth-library-java@7f2c535)) ### Bug Fixes * updates executable response spec for executable-sourced credentials ([googleapis#955](googleapis/google-auth-library-java#955)) ([48ff83d](googleapis/google-auth-library-java@48ff83d)) ### Documentation * **samples:** added auth samples and tests ([googleapis#927](googleapis/google-auth-library-java#927)) ([32c717f](googleapis/google-auth-library-java@32c717f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chingor13 @frankyn This should be fully backwards compatible at an an API and behavior level. However it does strongly warn developers not to encode spaces as plus. I'd prefer to disable that completely, but the last time we tried that it broke some downstream projects, so this is a more nudging approach to get clients to stop doing this.