-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release google-http-java-client v1.31.0 #754
Release google-http-java-client v1.31.0 #754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release process should not create 1.31.0-SNAPSHOT? That's fine if so. I just ask because I know some of our other release processes never commit non-SNAPSHOT versions to head so I want to make sure that isn't the case here.
@elharo, this PR changes everything from -SNAPSHOT to the latest version (1.31.0), unless I'm missing something you're seeing, can you share a link? |
Yes, and my question is whether we want to do that? Some release processes jump straight from 1.30.2-SNAPSHOT to 1.31.0-SNAPSHOT when releasing 1.30.2 and have the non-SNAPSHOT version only on branches. But it sounds like that's not how yoshi works? |
@elharo We have one commit in master that has the non snapshot which is tagged for the release (rather than a long lived branch). The next commit is a snapshot bump. |
The release build has started, the log can be viewed here. 🌻 |
🥚 You hatched a release! The release build finished successfully! 💜 |
…#754) * disabling self-signed jwt for domain wide delegation * fix: nit fixes
This pull request was generated using releasetool.
07-31-2019 07:21 PDT
Implementation Changes
New Features
Dependencies
Documentation
Internal / Testing Changes