Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode post data only once #649

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import com.google.api.client.util.BackOff;
import com.google.api.client.util.Key;
import com.google.api.client.util.LoggingStreamingContent;
import com.google.api.client.util.StreamingContent;
import com.google.api.client.util.StringUtils;
import com.google.api.client.util.Value;
import com.google.common.base.Charsets;
Expand All @@ -33,6 +34,7 @@
import com.google.common.collect.Lists;
import java.io.ByteArrayInputStream;
import java.io.IOException;
import java.io.OutputStream;
import java.util.Arrays;
import java.util.List;
import java.util.concurrent.ExecutionException;
Expand Down Expand Up @@ -1264,4 +1266,56 @@ public void testExecute_curlLoggerWithContentEncoding() throws Exception {
}
assertTrue(found);
}

public void testExecute_shouldEncodeContentOnce() throws IOException {
class TestEncoding implements HttpEncoding {

private int encodingCount = 0;

@Override
public String getName() {
return "test-encoding";
}

@Override
public void encode(StreamingContent content, OutputStream out) throws IOException {
encodingCount++;
return;
}

public int getEncodingCount() {
return encodingCount;
}
}

class NullOutputStream extends OutputStream {
@Override
public void write(int b) throws IOException {
}
}
final LowLevelHttpRequest lowLevelHttpRequest =
new MockLowLevelHttpRequest() {
@Override
public LowLevelHttpResponse execute() throws IOException {
// LowLevelRequest implementations will use writeTo for the request body
getStreamingContent().writeTo(new NullOutputStream());
return super.execute();
}
};
HttpTransport transport =
new MockHttpTransport() {
@Override
public LowLevelHttpRequest buildRequest(String method, String url) throws IOException {
return lowLevelHttpRequest;
}
};
HttpContent content = new EmptyContent();
TestEncoding encoding = new TestEncoding();
HttpRequest request =
transport.createRequestFactory().buildPostRequest(HttpTesting.SIMPLE_GENERIC_URL, content);
request.setEncoding(encoding);
request.execute();

assertEquals(1, encoding.getEncodingCount());
}
}