Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Republish the fixed apache extensions as google-http-client-apache-v2 #637

Merged
merged 12 commits into from
May 15, 2019

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented May 14, 2019

1.29.0 reverted the changes that split the google-http-client-apache artifact out of google-http-client. Rather than "breaking" the original artifact, we will provide a new artifact google-http-client-apache-v2 which provides a new package com.google.api.client.http.apache.v2.

This also removes the google-http-client-apache and google-http-client-apache-legacy modules. The legacy code still exists in the base google-http-client artifact and is now deprecated.

The new artifact will be versioned the same as the rest of the packages (so will start at 1.30.0 when first released).

@chingor13 chingor13 requested a review from a team as a code owner May 14, 2019 22:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 14, 2019
@chingor13 chingor13 requested a review from elharo May 15, 2019 00:07
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the version needs to move to 130.0-SNAPSHOT before or during this PR. Right now there's a mix of 1.29.2 and 1.30.0 here.

<version>2.1.2-SNAPSHOT</version><!-- {x-version-update:google-http-client-apache:current} -->
<name>Apache HTTP transport for the Google HTTP Client Library for Java.</name>
<artifactId>google-http-client-apache-v2</artifactId>
<version>1.29.2-SNAPSHOT</version><!-- {x-version-update:google-http-client-apache-v2:current} -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we jump to 1.30.0-SNAPSHOT?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our release tools will correctly version bump all of the artifacts. This should be included in the 1.30.0 release.

ApacheHttpRequest(HttpClient httpClient, HttpRequestBase request) {
this.httpClient = httpClient;
this.request = request;
this.requestConfig = RequestConfig.custom().setRedirectsEnabled(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the sort of detail—no redirects—it's useful to include in library documentation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more of an implementation detail. google-http-client configures redirects so we turn off the underlying automatic redirects in the Apache client.


ApacheHttpTransport transport = new ApacheHttpTransport(mockClient);

// Test GET.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should probably be seven separate methods with a common setup here.

@chingor13 chingor13 merged commit 1f28f54 into googleapis:master May 15, 2019
@chingor13 chingor13 deleted the apache-v2 branch May 15, 2019 16:27
@chingor13 chingor13 mentioned this pull request May 15, 2019
2 tasks
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants