Made lazy serialization on calling getLength() or writeTo() methods #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
This PR increases the memory used by the client. I think that for now, we ought to drop this line of work. |
clundin25
pushed a commit
to clundin25/google-http-java-client
that referenced
this pull request
Aug 11, 2022
* ADC can load impersonation credentials * Add tests for new features in ImpersonationCredentials * Add tests for GoogleCredentials * Fix linter errors * Fix linter errors in ImpersonatedCredentialsTest * Fix issues after receiving comments * Fix lint errors * Handle ClassCastException in fromJson * Fix lint errors * minor refactoring * fix doc strings * fix lint errors * delegates can be missing from the json file * Mark test using @test() * Remove redundant methods and handle exceptions * add an empty file * remove an empty file * Fix docstring and move one variable to inner scope. * Refactor ImpersonatedCredentialsTest * Reformat the ImpersonatedCredentialsTest * Remove redundant checks in tests * Use VisibleForTesting annotation to limit visibility Co-authored-by: Elliotte Rusty Harold <elharo@users.noreply.github.com>
clundin25
pushed a commit
to clundin25/google-http-java-client
that referenced
this pull request
Aug 11, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [0.27.0](https://github.com/googleapis/google-auth-library-java/compare/v0.26.0...v0.27.0) (2021-07-14) ### Features * add Id token support for UserCredentials ([googleapis#650](https://github.com/googleapis/google-auth-library-java/issues/650)) ([5a8f467](https://github.com/googleapis/google-auth-library-java/commit/5a8f4676630854c53aa708a9c8b960770067f858)) * add impersonation credentials to ADC ([googleapis#613](https://github.com/googleapis/google-auth-library-java/issues/613)) ([b9823f7](https://github.com/googleapis/google-auth-library-java/commit/b9823f70d7f3f7461b7de40bee06f5e7ba0e797c)) * Adding functional tests for Service Account ([googleapis#685](https://github.com/googleapis/google-auth-library-java/issues/685)) ([dfe118c](https://github.com/googleapis/google-auth-library-java/commit/dfe118c261aadf137a3cf47a7acb9892c7a6db4d)) * allow scopes for self signed jwt ([googleapis#689](https://github.com/googleapis/google-auth-library-java/issues/689)) ([f4980c7](https://github.com/googleapis/google-auth-library-java/commit/f4980c77566bbd5ef4c532acb199d7d484dbcd01)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #283