Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Rake version to prepare Ruby 3 keyword arguments support #4897

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Bump Rake version to prepare Ruby 3 keyword arguments support #4897

merged 1 commit into from
Mar 4, 2020

Conversation

yahonda
Copy link
Contributor

@yahonda yahonda commented Mar 3, 2020

Related to #4884

To prepare Ruby 3 keyword arguments support, there are some other gems also need update. rake is one of them.

I have bumped all of Rake under google-cloud-ruby repository.

Related to #4884

To prepare Ruby 3 keyword arguments support, there are some other gems also need update. `rake` is one of them.

* Rake 13.0.0 supports Ruby 3 keyword arguments by ruby/rake#326
* Rake 13 drops Ruby 2.1 or older support by ruby/rake#325
* Gems under `google-cloud-ruby` repository only supports Ruby 2.4 or higher then dropping Ruby 2.1 support should not be an issue.

I have bumped all of Rake under `google-cloud-ruby` repository.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 3, 2020
@quartzmo quartzmo requested a review from dazuma March 3, 2020 16:18
@quartzmo
Copy link
Member

quartzmo commented Mar 3, 2020

@yahonda Thank you for this PR, and sorry this wasn't done already. We really appreciate that you took the time to update all packages.

Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this branch and tested it locally with Ruby 2.4.5 and 2.6.5. No issues.

@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2020
@quartzmo quartzmo merged commit ea214de into googleapis:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants