Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoML Tables: Enable users to pass in Pandas Dataframe when calling import_data() and batch_predict() from AutoML Tables client #9116

Merged
merged 17 commits into from
Aug 28, 2019

Conversation

TrucHLe
Copy link
Contributor

@TrucHLe TrucHLe commented Aug 27, 2019

This PR:

  • Adds an optional param called pandas_dataframe to import_data() and batch_predict() of the Tables client.
  • Adds a Google Cloud Storage (GCS) client and invoke it from the Tables client whenever user wants to directly import a Pandas Dataframe.
  • Adds new unit & system test cases to cover the new use case.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2019
Copy link
Contributor

@lwander lwander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! Just a few small comments

automl/google/cloud/automl_v1beta1/tables/gcs_client.py Outdated Show resolved Hide resolved
automl/google/cloud/automl_v1beta1/tables/gcs_client.py Outdated Show resolved Hide resolved
automl/google/cloud/automl_v1beta1/tables/gcs_client.py Outdated Show resolved Hide resolved
automl/google/cloud/automl_v1beta1/tables/tables_client.py Outdated Show resolved Hide resolved
automl/google/cloud/automl_v1beta1/tables/tables_client.py Outdated Show resolved Hide resolved
automl/google/cloud/automl_v1beta1/tables/tables_client.py Outdated Show resolved Hide resolved
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 I'm not completely sold on the added value of this wrapper. Perhaps this would be better suited for a sample than a library method? @sirtorry?

automl/setup.py Outdated Show resolved Hide resolved
automl/setup.py Outdated Show resolved Hide resolved
automl/setup.py Outdated Show resolved Hide resolved
@lwander
Copy link
Contributor

lwander commented Aug 27, 2019

👋 I'm not completely sold on the added value of this wrapper.

We want to simplify the experience for datascientists in jupyter notebooks as much as possible. Typically they are doing feature engineering & data-processing on dataframes, and we don't want them to have to copy-paste a sample or learn to use another client library for simple things like this.

@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2019
Copy link
Contributor Author

@TrucHLe TrucHLe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First wave of comments resolved 😃 !

@sirtorry sirtorry self-requested a review August 28, 2019 05:40
@tseaver tseaver added api: automl Issues related to the AutoML API. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 28, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 28, 2019
Copy link
Contributor

@lwander lwander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 2 last comments from my end

@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 28, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 28, 2019
@busunkim96 busunkim96 merged commit 0c7dd62 into googleapis:master Aug 28, 2019
HemangChothani pushed a commit to HemangChothani/google-cloud-python that referenced this pull request Aug 29, 2019
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
parthea pushed a commit that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: automl Issues related to the AutoML API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants