Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#828: Clarify nature of pubsub-surface document. #842

Merged
merged 1 commit into from
Apr 29, 2015
Merged

#828: Clarify nature of pubsub-surface document. #842

merged 1 commit into from
Apr 29, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Apr 23, 2015

  • Rename to pubsub-usage.
  • Update title to "Using the API".

Fixes #828.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2015
@dhermes
Copy link
Contributor

dhermes commented Apr 23, 2015

LGTM. Not sure if you want to discuss with @jgeewax or not?

@tseaver
Copy link
Contributor Author

tseaver commented Apr 23, 2015

I'll let @jgeewax comment, as I'm not sure this change reflects his intent in #828.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling efac05b on tseaver:828-pubsub_surface_doc_purpose into 286207b on GoogleCloudPlatform:master.

@jgeewax
Copy link
Contributor

jgeewax commented Apr 29, 2015

LGTM.

@tseaver
Clarify nature of 'pubsub-surface' document.
3db06e5 
- Rename to 'pubsub-usage'.

- Update title.

Fixes #828.
@tseaver
Copy link
Contributor Author

tseaver commented Apr 29, 2015

I will merge after Travis: I amended to commit message to fix the wrong issue number.

@tseaver tseaver mentioned this pull request Apr 29, 2015
Closed
tseaver added a commit that referenced this pull request Apr 29, 2015
@tseaver
Merge pull request #842 from tseaver/828-pubsub_surface_doc_purpose
9568703 
#828: Clarify nature of `pubsub-surface` document.
@tseaver tseaver merged commit 9568703 into googleapis:master Apr 29, 2015
@tseaver tseaver deleted the 828-pubsub_surface_doc_purpose branch April 29, 2015 17:27
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3db06e5 on tseaver:828-pubsub_surface_doc_purpose into 286207b on GoogleCloudPlatform:master.

@dhermes dhermes mentioned this pull request Jun 4, 2015
Merged
atulep pushed a commit that referenced this pull request Apr 6, 2023
@gguuss @busunkim96
Updates client version for compatibility with language [(#842)](Googl…
c601784 
…eCloudPlatform/python-docs-samples#842)
atulep pushed a commit that referenced this pull request Apr 6, 2023
@gguuss @busunkim96
Updates client version for compatibility with language [(#842)](Googl…
81515af 
…eCloudPlatform/python-docs-samples#842)
atulep pushed a commit that referenced this pull request Apr 18, 2023
@gguuss @busunkim96
Updates client version for compatibility with language [(#842)](Googl…
b38c908 
…eCloudPlatform/python-docs-samples#842)
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gguuss @busunkim96
Updates client version for compatibility with language [(#842)](Googl…
ae3149f 
…eCloudPlatform/python-docs-samples#842)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pub/Sub surface doc title should be "Summary" or "Quick start" or "Overview" or "Common tasks"
5 participants
@tseaver @dhermes @coveralls @jgeewax @googlebot