Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move JSON / discovery connection to shared connection module #746

Merged
merged 5 commits into from
Mar 19, 2015
Merged

Move JSON / discovery connection to shared connection module #746

merged 5 commits into from
Mar 19, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 19, 2015

See discussion in #742 for context.

@dhermes
Moving storage Connection behavior into shared class.
39101c6
@dhermes
Removing upload boolean from JSONConnection.
7fb81c5
@dhermes
Moving storage connection tests over for JSONConnection.
58c4476 
- Had to add a mock class with API_URL_TEMPLATE, API_BASE_URL,
  API_VERSION set so we could test some methods.
- Removed unused imports in storage.connection module
- Rewrote some 'from httplib2 import Http' imports to avoid
  lint errors.
@dhermes
Making pubsub Connection inherit from JSONConnection.
da1ec9e
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 19, 2015
@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 19, 2015
@tseaver
Copy link
Contributor

tseaver commented Mar 19, 2015

LGTM pending Travis (I cancelled the build for da1ec9e).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4baf1ec on dhermes:move-connection-to-shared into 01d697e on GoogleCloudPlatform:master.

dhermes added a commit that referenced this pull request Mar 19, 2015
@dhermes
Merge pull request #746 from dhermes/move-connection-to-shared
8948a49 
Move JSON / discovery connection to shared connection module
@dhermes dhermes merged commit 8948a49 into googleapis:master Mar 19, 2015
@dhermes dhermes deleted the move-connection-to-shared branch March 19, 2015 22:15
@dhermes dhermes mentioned this pull request Apr 9, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @tseaver @coveralls @googlebot