Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserving indexed=False from parsed proto Values. #541

Merged
merged 2 commits into from
Jan 15, 2015
Merged

Preserving indexed=False from parsed proto Values. #541

merged 2 commits into from
Jan 15, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jan 14, 2015

Fixes #513.

@dhermes dhermes added api: datastore Issues related to the Datastore API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jan 14, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 99c1a0b on dhermes:fix-513 into 8a42ef5 on GoogleCloudPlatform:master.

tseaver
tseaver reviewed Jan 14, 2015
View reviewed changes
gcloud/datastore/helpers.py

for property_pb in pb.property:
value = _get_value_from_property_pb(property_pb)
entity[property_pb.name] = value
entity_props[property_pb.name] = value
if not property_pb.value.indexed:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 15, 2015
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0647c93 on dhermes:fix-513 into * on GoogleCloudPlatform:master*.

@dhermes
Copy link
Contributor Author

dhermes commented Jan 15, 2015

@tseaver rebased and list values handled in 7720cc0

PTAL

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 7720cc0 on dhermes:fix-513 into 55285f9 on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor

tseaver commented Jan 15, 2015

LGTM

dhermes added a commit that referenced this pull request Jan 15, 2015
@dhermes
Merge pull request #541 from dhermes/fix-513
edfd5e2 
Preserving indexed=False from parsed proto `Value`s.
@dhermes dhermes merged commit edfd5e2 into googleapis:master Jan 15, 2015
@dhermes dhermes deleted the fix-513 branch January 15, 2015 20:43
parthea pushed a commit that referenced this pull request Aug 15, 2023
@gcf-owl-bot
chore: [autoapprove] Pin flake8 version (#541)
6ebee6d 
Source-Link: https://github.com/googleapis/synthtool/commit/0ddbff8012e47cde4462fe3f9feab01fbc4cdfd6
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bced5ca77c4dda0fd2f5d845d4035fc3c5d3d6b81f245246a36aee114970082b
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@gcf-owl-bot
chore: resolve issue with prerelease presubmit [autoapprove] (#541)
6142705 
Source-Link: googleapis/synthtool@1b9ad76
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9db98b055a7f8bd82351238ccaacfd3cda58cdf73012ab58b8da146368330021
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: Update gapic-generator-python to v1.11.2 (#541)
081b705 
* chore: Update gapic-generator-python to v1.11.2

PiperOrigin-RevId: 546510849

Source-Link: googleapis/googleapis@736073a

Source-Link: googleapis/googleapis-gen@deb64e8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGViNjRlOGVjMTlkMTQxZTMxMDg5ZmU5MzJiM2E5OTdhZDU0MWM0ZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@yoshi-automation @busunkim96
feat: add search_all_resources and search_all_iam_policies (via s…
f79346e 
…ynth) (#32)

* changes without context

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.

* fix: consolidate logging setup (#541)

* fix: consolidate logging setup

When switching autosynth to use synthtool's git module, we transitively
load synthtool's logger setup which adds a log handler globally. This
causes logs to be emitted twice (with 2 different styles).

This consolidates the logging setup into a single helper and now both
autosynth's and synthtool's logger instance use the same configuration
(with different logger names).

* fix: add the level name when the log isn't colorize

Source-Author: Jeff Ching <chingor@google.com>
Source-Date: Tue May 12 15:53:43 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: c585ac3b5eff5cd2097a5315ffd9cf4823cc1ed2
Source-Link: googleapis/synthtool@c585ac3

* cloudasset: add SearchAllResources and SearchAllIamPolicies RPCs

PiperOrigin-RevId: 311601348

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu May 14 14:03:19 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 2433bd50656264a2ef9f684bf646fb4d250d39ff
Source-Link: googleapis/googleapis@2433bd5

* feat!: additional client library annotations
feat: reload information in the Document resource
BREAKING CHANGE: additional long-running operation annotations
BREAKING CHANGE: some existing request fields are now explicitly required
BREAKING CHANGE: the order of the Session resource patterns has changed

PiperOrigin-RevId: 312345206

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue May 19 13:46:01 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 7a8875d4bcf51993f6f7aa181066cc5ec95539d5
Source-Link: googleapis/googleapis@7a8875d

* Upgrade protoc-docs-plugin version to 0.7.0 to fix unstable docstrings.

PiperOrigin-RevId: 312689208

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu May 21 10:00:47 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: dec3204175104cef49bf21d685d5517caaf0058f
Source-Link: googleapis/googleapis@dec3204

* docs: Properly format literal strings.

PiperOrigin-RevId: 313202929

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue May 26 09:12:28 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: f563b1dffee42be2f61c326c39af4974c1984278
Source-Link: googleapis/googleapis@f563b1d

* docs: fix wrapping

Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Co-authored-by: Bu Sun Kim <busunkim@google.com>
parthea added a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot @parthea
chore: Update gapic-generator-python to v1.8.2 (#541)
ab57db1 
* chore: Update gapic-generator-python to v1.8.2

PiperOrigin-RevId: 504289125

Source-Link: googleapis/googleapis@38a48a4

Source-Link: googleapis/googleapis-gen@b2dc226
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJkYzIyNjYzZGJlNDdhOTcyYzhkOGMyZjhhNGRmMDEzZGFmZGNiYyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: Update gapic-generator-python to v1.11.2 (#541)
121f8ef 
* chore: Update gapic-generator-python to v1.11.2

PiperOrigin-RevId: 546510849

Source-Link: googleapis/googleapis@736073a

Source-Link: googleapis/googleapis-gen@deb64e8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGViNjRlOGVjMTlkMTQxZTMxMDg5ZmU5MzJiM2E5OTdhZDU0MWM0ZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Entity indexed=False not preserved in helpers.entity_from_protobuf
4 participants
@dhermes @coveralls @tseaver @googlebot