Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery & Storage: use client http for resumable media #3705

Merged
merged 3 commits into from
Jul 31, 2017

Conversation

theacodes
Copy link
Contributor

Resolves #3689

@theacodes theacodes added api: bigquery Issues related to the BigQuery API. api: storage Issues related to the Cloud Storage API. labels Jul 31, 2017
@theacodes theacodes requested a review from dhermes July 31, 2017 18:16
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2017
@theacodes
Copy link
Contributor Author

(FYI: System tests verified locally)

Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

client = mock.Mock(spec=[u'_credentials'])
def test__get_transport(self):
client = mock.Mock(spec=[u'_credentials', '_http'])
client._http = mock.sentinel.http

This comment was marked as spam.

This comment was marked as spam.

@theacodes theacodes merged commit 6dc55fd into googleapis:master Jul 31, 2017
@theacodes theacodes deleted the requests-for-resumable branch July 31, 2017 19:30
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
)

* BigQuery: Use client transport for resumable media
* Storage: Use client transport for resumable media
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
)

* BigQuery: Use client transport for resumable media
* Storage: Use client transport for resumable media
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
)

* BigQuery: Use client transport for resumable media
* Storage: Use client transport for resumable media
parthea pushed a commit that referenced this pull request Oct 21, 2023
…CloudPlatform/python-docs-samples#3705)

* Add main function to attestation verification script.

fixes #3704

* Add newline to end of file

* remove a blank line at the end

Co-authored-by: Benson Kuang <benkuang@google.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants