Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #174: verify Entity.__repr__ logic #253

Merged
merged 3 commits into from
Oct 17, 2014
Merged

Fix #174: verify Entity.__repr__ logic #253

merged 3 commits into from
Oct 17, 2014

Commits on Oct 17, 2014

  1. Avoid interior use of 'key()' setter-getter. 

    Instead, use '_key' directly, adding a '_must_key' property which
raises a NoKey exception if None (for use in cases which require a key).

Allows removal of the pylint 'maybe-no-member' comments.
    @tseaver
    tseaver committed Oct 17, 2014
    Configuration menu
    Copy the full SHA
    7c55a04 View commit details
    Browse the repository at this point in the history

  2. Add tests for logic in Entity.__repr__. 

    Fixes #174.
    @tseaver
    tseaver committed Oct 17, 2014
    Configuration menu
    Copy the full SHA
    64c711e View commit details
    Browse the repository at this point in the history

  3. Clarify docstring for 'Entity._must_key'. 

    Incorporates feedback from @dhermes.
    @tseaver
    tseaver committed Oct 17, 2014
    Configuration menu
    Copy the full SHA
    961e695 View commit details
    Browse the repository at this point in the history